From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752365AbbJNClk (ORCPT ); Tue, 13 Oct 2015 22:41:40 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:33003 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751608AbbJNClg convert rfc822-to-8bit (ORCPT ); Tue, 13 Oct 2015 22:41:36 -0400 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.0 \(3094\)) Subject: Re: [RFC] arm64: ioremap: add ioremap_cache macro From: yalin wang In-Reply-To: <20151013152011.GE11573@e104818-lin.cambridge.arm.com> Date: Wed, 14 Oct 2015 10:41:26 +0800 Cc: Will Deacon , mark.rutland@arm.com, toshi.kani@hp.com, andre.przywara@arm.com, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, treding@nvidia.com, mingo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 8BIT Message-Id: <2731BCF2-D0C0-4B77-A59F-FF3AB2A725D6@gmail.com> References: <1444616898-5057-1-git-send-email-yalin.wang2010@gmail.com> <20151013141055.GC11573@e104818-lin.cambridge.arm.com> <20151013142326.GM21550@arm.com> <20151013152011.GE11573@e104818-lin.cambridge.arm.com> To: Catalin Marinas X-Mailer: Apple Mail (2.3094) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Oct 13, 2015, at 23:20, Catalin Marinas wrote: > > On Tue, Oct 13, 2015 at 03:23:27PM +0100, Will Deacon wrote: >> On Tue, Oct 13, 2015 at 03:10:55PM +0100, Catalin Marinas wrote: >>> On Mon, Oct 12, 2015 at 10:28:18AM +0800, yalin wang wrote: >>>> Add ioremap_cache macro, because some code will test if this macro >>>> is defined or not, and will generate a generric version if not defined, >>>> for example, memremap.c do like this. >>>> >>>> Signed-off-by: yalin wang >>>> --- >>>> arch/arm64/include/asm/io.h | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h >>>> index 44be1e0..d6b620c 100644 >>>> --- a/arch/arm64/include/asm/io.h >>>> +++ b/arch/arm64/include/asm/io.h >>>> @@ -172,6 +172,7 @@ extern void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size); >>>> #define ioremap_wc(addr, size) __ioremap((addr), (size), __pgprot(PROT_NORMAL_NC)) >>>> #define ioremap_wt(addr, size) __ioremap((addr), (size), __pgprot(PROT_DEVICE_nGnRE)) >>>> #define iounmap __iounmap >>>> +#define ioremap_cache ioremap_cache >>> >>> Applied. Thanks. >> >> I'm not sure we want this. See: >> >> https://lkml.org/lkml/2015/10/9/699 > > Thanks Will and Arnd, I missed this. Patch reverted. > i don’t understand why conflict with Dan Williams’ patch. Dan Williams ’s patch also define ioremap_cache for arch ia64 & arch sh & arch xtensa , i see this : # git show 92281dee825f am i miss something? Thanks