From: Randy Dunlap <rdunlap@infradead.org>
To: Udo van den Heuvel <udovdh@xs4all.nl>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-leds@vger.kernel.org, Dan Murphy <dmurphy@ti.com>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: disabling CONFIG_LED_CLASS
Date: Tue, 13 Oct 2020 22:07:45 -0700 [thread overview]
Message-ID: <2739e1fd-75c6-4e43-cd79-9028479f91bf@infradead.org> (raw)
In-Reply-To: <eadc23e7-b383-e2fc-6e20-ed22745d0bfc@xs4all.nl>
On 10/13/20 9:56 PM, Udo van den Heuvel wrote:
> On 14-10-2020 06:49, Randy Dunlap wrote:
>> If you disable SND_HDA_CODEC_REALTEK, then the rest of the
>> LED kconfig symbols can be disabled.
>
> Sure,
>
> but:
>
> # dmesg|grep audi
> (...)
>
> [ 19.971537] snd_hda_codec_generic hdaudioC0D0: ignore pin 0x7, too
> many assigned pins
> [ 19.973547] snd_hda_codec_generic hdaudioC0D0: autoconfig for
> Generic: line_outs=0 (0x0/0x0/0x0/0x0/0x0) type:line
> [ 19.975642] snd_hda_codec_generic hdaudioC0D0: speaker_outs=0
> (0x0/0x0/0x0/0x0/0x0)
> [ 19.977774] snd_hda_codec_generic hdaudioC0D0: hp_outs=0
> (0x0/0x0/0x0/0x0/0x0)
> [ 19.980176] snd_hda_codec_generic hdaudioC0D0: mono: mono_out=0x0
> [ 19.982257] snd_hda_codec_generic hdaudioC0D0: dig-out=0x3/0x5
> [ 19.984412] snd_hda_codec_generic hdaudioC0D0: inputs:
> [ 20.035088] snd_hda_codec_realtek hdaudioC1D0: autoconfig for
> ALC1220: line_outs=3 (0x14/0x15/0x16/0x0/0x0) type:line
> [ 20.036940] snd_hda_codec_realtek hdaudioC1D0: speaker_outs=0
> (0x0/0x0/0x0/0x0/0x0)
> [ 20.039579] snd_hda_codec_realtek hdaudioC1D0: hp_outs=1
> (0x1b/0x0/0x0/0x0/0x0)
> [ 20.041690] snd_hda_codec_realtek hdaudioC1D0: mono: mono_out=0x0
> [ 20.044076] snd_hda_codec_realtek hdaudioC1D0: dig-out=0x1e/0x0
> [ 20.046173] snd_hda_codec_realtek hdaudioC1D0: inputs:
> [ 20.049252] snd_hda_codec_realtek hdaudioC1D0: Front Mic=0x19
> [ 20.051287] snd_hda_codec_realtek hdaudioC1D0: Rear Mic=0x18
> [ 20.053084] snd_hda_codec_realtek hdaudioC1D0: Line=0x1a
> [ 20.427487] usbcore: registered new interface driver snd-usb-audio
>
> I.e.: it looks like I will lose some funcionality when I disable
> SND_HDA_CODEC_REALTEK.
OK. At present you can't have it both ways, i.e., SND_HDA_CODEC_REALTEK
with no LEDS. That driver apparently wants LEDS.
According to this commit:
commit 7cdf8c49b1df0a385db06c4f9a5ba1b16510fdcc
Author: Takashi Iwai <tiwai@suse.de>
Date: Thu Jun 18 13:08:31 2020 +0200
ALSA: hda: generic: Add a helper for mic-mute LED with LED classdev
the Realtek and other drivers need LED support:
"""
Also, introduce a new kconfig CONFIG_SND_HDA_GENERIC_LEDS, to indicate
the usage of mute / mic-mute LED helpers. It's selected by the codec
drivers (Realtek, Conexant and Sigmatel), while it selects the
necessary LED class dependencies.
"""
--
~Randy
next prev parent reply other threads:[~2020-10-14 8:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 9:24 Udo van den Heuvel
2020-10-13 13:24 ` Udo van den Heuvel
2020-10-13 15:53 ` Randy Dunlap
2020-10-13 16:03 ` Randy Dunlap
2020-10-14 4:29 ` Udo van den Heuvel
2020-10-14 4:34 ` Randy Dunlap
2020-10-14 4:39 ` Udo van den Heuvel
2020-10-14 4:49 ` Randy Dunlap
2020-10-14 4:56 ` Udo van den Heuvel
2020-10-14 5:07 ` Randy Dunlap [this message]
2020-10-14 5:16 ` Udo van den Heuvel
2020-10-14 5:54 ` disabling CONFIG_LED_CLASS (SND_HDA_CODEC_REALTEK) Randy Dunlap
2020-10-14 7:49 ` Takashi Iwai
2020-10-14 7:51 ` Takashi Iwai
2020-10-14 7:58 ` Pavel Machek
2020-10-14 8:05 ` Udo van den Heuvel
2020-10-14 8:11 ` Pavel Machek
2020-10-14 8:22 ` Udo van den Heuvel
2020-10-14 8:27 ` Pavel Machek
2020-10-14 8:34 ` Udo van den Heuvel
2020-10-14 8:37 ` Pavel Machek
2020-10-19 8:35 ` Udo van den Heuvel
2020-10-19 10:58 ` Marek Behún
2020-10-14 8:06 ` Takashi Iwai
2020-10-14 7:54 ` Pavel Machek
2020-10-14 8:08 ` Takashi Iwai
2020-10-14 8:13 ` Pavel Machek
2020-10-14 8:17 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2739e1fd-75c6-4e43-cd79-9028479f91bf@infradead.org \
--to=rdunlap@infradead.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=udovdh@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®