From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86DFCC41513 for ; Fri, 4 Aug 2023 14:20:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231681AbjHDOUk (ORCPT ); Fri, 4 Aug 2023 10:20:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231468AbjHDOUi (ORCPT ); Fri, 4 Aug 2023 10:20:38 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E1EA11B; Fri, 4 Aug 2023 07:20:37 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3285E1F8B0; Fri, 4 Aug 2023 14:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691158836; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CSB5apA+271QhFsINBD70EU+4xw+qMjisa/GtmIDpPg=; b=Q1wX933b9Q4sPjTYKayx5kBeJJR3hF0gKtW/dzIc0F2MBXwRNhiVakyaDk//JxSvsbpZh8 BOSjSnXkmHUjQgAc+6x6nLoX3xj5vWOUqMizNQ9ZiJIpCQTDPIveDffvFGpVxpLOL1qXyX Cxxk7pOcp9BRAzYdQNZwvXiozP6a5Xg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691158836; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CSB5apA+271QhFsINBD70EU+4xw+qMjisa/GtmIDpPg=; b=oE3q6r8GQVlE26fq8v7Sy1kkRKsOziGkK8+HbsyWEDg+GQqqQFuxi+RwHDbjq6uvaTe67+ YSChD46rELjkSTAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F20DE13904; Fri, 4 Aug 2023 14:20:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rMS/OTMJzWSgMQAAMHmgww (envelope-from ); Fri, 04 Aug 2023 14:20:35 +0000 Message-ID: <273c9c99-dc2f-2854-bbc1-70b22b5589d8@suse.de> Date: Fri, 4 Aug 2023 16:20:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: XFS metadata CRC errors on zram block device on ppc64le architecture Content-Language: en-US To: Christoph Hellwig , Sergey Senozhatsky Cc: Dusty Mabe , wq@lst.de, Minchan Kim , Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Andrew Morton , marmijo@redhat.com References: <20230802094106.GA28187@lst.de> <3f36882c-b429-3ece-989b-a6899c001cbd@suse.de> <43843fec-f30a-1edc-b428-1d38ddb1050f@dustymabe.com> <20230804032523.GA81493@google.com> <20230804134248.GA26611@lst.de> From: Hannes Reinecke In-Reply-To: <20230804134248.GA26611@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/4/23 15:42, Christoph Hellwig wrote: > FYI, I've found an arm64 system with 16k page size support, and while > I can't reproduce the exact issue, I do see corruption with I/O test > on zram that don't show on the same system with 4k pages. I'm trying > to understand the details at the moment. > For some reason zram run with a logical block size of 4k: #define ZRAM_LOGICAL_BLOCK_SHIFT 12 #define ZRAM_LOGICAL_BLOCK_SIZE (1 << ZRAM_LOGICAL_BLOCK_SHIFT) so we'll have sub-page accesses for larger page sizes. My bet is that the issue goes away if we set the logical block size to page size ... Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman