From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755281AbeARQJq (ORCPT <rfc822;w@1wt.eu>);
        Thu, 18 Jan 2018 11:09:46 -0500
Received: from thoth.sbs.de ([192.35.17.2]:56650 "EHLO thoth.sbs.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753406AbeARQJo (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 18 Jan 2018 11:09:44 -0500
Subject: Re: [PATCH] scripts/gdb: fix get_thread_info
To: Kieran Bingham <kbingham@kernel.org>,
        Xi Kangjie <imxikangjie@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
References: <20180118210159.17223-1-imxikangjie@gmail.com>
 <c92773fb-41c8-ba41-0c76-344cef7cd01b@siemens.com>
 <782503b9-83fc-6a47-24ba-524a728da642@kernel.org>
From: Jan Kiszka <jan.kiszka@siemens.com>
Message-ID: <273f82e8-7419-a636-c7d3-a0857b478ade@siemens.com>
Date: Thu, 18 Jan 2018 16:50:21 +0100
User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12)
 Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666
MIME-Version: 1.0
In-Reply-To: <782503b9-83fc-6a47-24ba-524a728da642@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2018-01-18 16:47, Kieran Bingham wrote:
> 
> On 18/01/18 15:43, Jan Kiszka wrote:
>> On 2018-01-18 22:01, Xi Kangjie wrote:
>>> Since kernel 4.9, the thread_info has been moved into task_struct,
>>> no longer locates at the bottom of kernel stack.
>>>
>>> See commits:
>>> - commit c65eacbe290b ("sched/core: Allow putting thread_info into
>>> task_struct")
>>> - commit 15f4eae70d36 ("x86: Move thread_info into task_struct")
>>>
>>> Before fix:
>>> (gdb) set $current = $lx_current()
>>> (gdb) p $lx_thread_info($current)
>>> $1 = {flags = 1470918301}
>>> (gdb) p $current.thread_info
>>> $2 = {flags = 2147483648}
>>>
>>> After fix:
>>> (gdb) p $lx_thread_info($current)
>>> $1 = {flags = 2147483648}
>>> (gdb) p $current.thread_info
>>> $2 = {flags = 2147483648}
>>>
>>> Signed-off-by: Xi Kangjie <imxikangjie@gmail.com>
>>> ---
>>>  scripts/gdb/linux/tasks.py | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/scripts/gdb/linux/tasks.py b/scripts/gdb/linux/tasks.py
>>> index 1bf949c43b76..f6ab3ccf698f 100644
>>> --- a/scripts/gdb/linux/tasks.py
>>> +++ b/scripts/gdb/linux/tasks.py
>>> @@ -96,6 +96,8 @@ def get_thread_info(task):
>>>          thread_info_addr = task.address + ia64_task_size
>>>          thread_info = thread_info_addr.cast(thread_info_ptr_type)
>>>      else:
>>> +        if task.type.fields()[0].type == thread_info_type.get_type():
>>> +            return task['thread_info']
>>>          thread_info = task['stack'].cast(thread_info_ptr_type)
>>>      return thread_info.dereference()
>>>  
>>>
>>
>> Acked-by: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Andrew, please pick up.
> 
> Acked-by: Kieran Bingham <kbingham@kernel.org>
> 
> However, should we mark this as:
>   Cc: <stable@vger.kernel.org> # 4.9+ ?
> 

Yes, good point.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux