From: "Prakash, Prashanth" <pprakash@codeaurora.org>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
rjw@rjwysocki.net, lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI/CPC: Don't try to clean up uninitialized CPC data
Date: Fri, 16 Dec 2016 14:52:35 -0700 [thread overview]
Message-ID: <274267e0-d41a-83b1-b4d6-ee7af51ace49@codeaurora.org> (raw)
In-Reply-To: <1481913346-16321-1-git-send-email-boris.ostrovsky@oracle.com>
Hi Boris,
On 12/16/2016 11:35 AM, Boris Ostrovsky wrote:
> If acpi_cppc_processor_probe() had not executed successfully (for
> example, if _CPC object was not found) then cpc_desc_ptr for that
> processor will be invalid.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> ---
> drivers/acpi/cppc_acpi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index d0d0504..5bba26e 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -824,6 +824,8 @@ void acpi_cppc_processor_exit(struct acpi_processor *pr)
> void __iomem *addr;
>
> cpc_ptr = per_cpu(cpc_desc_ptr, pr->id);
> + if (!cpc_ptr)
> + return;
>
> /* Free all the mapped sys mem areas for this CPU */
> for (i = 2; i < cpc_ptr->num_entries; i++) {
I think a recent patch from Sebastian fixed the same issue.
https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=9e9d68dad58c70f40f50adfeabd2fdaa39a743fd
--
Thanks,
Prashanth
next prev parent reply other threads:[~2016-12-16 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 18:35 Boris Ostrovsky
2016-12-16 21:52 ` Prakash, Prashanth [this message]
2016-12-16 22:02 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=274267e0-d41a-83b1-b4d6-ee7af51ace49@codeaurora.org \
--to=pprakash@codeaurora.org \
--cc=boris.ostrovsky@oracle.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®