From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F33743C056 for ; Thu, 8 Jan 2026 13:25:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767878738; cv=none; b=PUPHcx04LoEfffOoZuf7QTEo6QCDLNxzcOgzZzai72/hFxszg+08VfH9ljL2CgLcQ5ZMdfLFbVu6fpC7ahtZxYAD3YBaktyNGxsG/wyoxYVVN7yhstLp4jueILH4dX0QqCrJbvX2h0qSwWC5HoWSTy3EihsZIHKORO+33cMcxok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767878738; c=relaxed/simple; bh=qHRz6GXdVjL/TCLKl/jsv1E/UXUZlOlgWVlKiQerEbY=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=OISUZosdM0gJf2ltRLf2COlijMDd3kpn7Vcc8Do5up8snCwKgmywlpoxD4CcKt6L4A6XcY5btI72KfYeaWgBZy/64ySU8zfYHsO1TnIIW7kAh8w/WE7XDncLdTiJEylbpU2HTZTku2k0f2STkrOjm4K48QWT7fcSFpkJfPesbQc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=M+7RJ8lV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M+7RJ8lV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767878736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zwgL+bXj+y0swOSQAFLhX4j8oF6Bac5odigTmsgHyuw=; b=M+7RJ8lV6dgWexa5tQzSJgrcRQkUySYyXbbmbe5EvMaHn1OJ+HzzDG2Mnl0b8Y4A6OQllm kflIMAVeEBTTrlhoRB0S7YktdjRbPU1r19/7yWAi8Fzr80YqsuIRD6eJmdzcleu4m4yDdH JF06UKvptj7MiWWDSAal8Er7b3S4gSs= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-392-HWqXTeLHPGW5EoIVcaeTFQ-1; Thu, 08 Jan 2026 08:25:31 -0500 X-MC-Unique: HWqXTeLHPGW5EoIVcaeTFQ-1 X-Mimecast-MFC-AGG-ID: HWqXTeLHPGW5EoIVcaeTFQ_1767878730 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 534321956048; Thu, 8 Jan 2026 13:25:30 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9F0DF19560A7; Thu, 8 Jan 2026 13:25:28 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20260107044215.109930-1-ebiggers@kernel.org> References: <20260107044215.109930-1-ebiggers@kernel.org> To: Eric Biggers Cc: dhowells@redhat.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Ard Biesheuvel , "Jason A . Donenfeld" , Herbert Xu Subject: Re: [PATCH] lib/crypto: mldsa: Add FIPS cryptographic algorithm self-test Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2743677.1767878727.1@warthog.procyon.org.uk> Date: Thu, 08 Jan 2026 13:25:27 +0000 Message-ID: <2743678.1767878727@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Eric Biggers wrote: > Since ML-DSA is FIPS-approved, add the boot-time self-test which is > apparently required. > > Just add a test vector manually for now, borrowed from > lib/crypto/tests/mldsa-testvecs.h (where in turn it's borrowed from > leancrypto). The SHA-* FIPS test vectors are generated by > scripts/crypto/gen-fips-testvecs.py instead, but the common Python > libraries don't support ML-DSA yet. > > Signed-off-by: Eric Biggers Reviewed-by: David Howells