From: Joe Perches <joe@perches.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Lin Ma <linma@zju.edu.cn>,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net/sched: mqprio: Add length check for TCA_MQPRIO_{MAX/MIN}_RATE64
Date: Tue, 25 Jul 2023 14:04:20 -0700 [thread overview]
Message-ID: <27446992c6fcc982a26085151988f7be3aa1e3d7.camel@perches.com> (raw)
In-Reply-To: <20230725125601.7ec04aa5@kernel.org>
On Tue, 2023-07-25 at 12:56 -0700, Jakub Kicinski wrote:
> On Tue, 25 Jul 2023 12:50:00 -0700 Joe Perches wrote:
> > > > What do you think the "case" is here?
> > > >
> > > > Do you think John Fastabend, who hasn't touched the file in 7+ years
> > > > should be cc'd? Why?
> > >
> > > Nope. The author of the patch under Fixes.
> >
> > It adds that already since 2019.
>
> Which is awesome! But for that to work you have to run get_maintainer
> on the patchfile not the file paths. Lin Ma used:
>
> # ./scripts/get_maintainer.pl net/sched/sch_mqprio.c
>
> That's what I keep complaining about. People run get_maintainer on
> paths and miss out on all the get_maintainer features which need
> to see the commit message.
Which is useful when editing a file but not when sending
a patch. get_maintainer does _both_.
Again, there's no issue with get_maintainer, but there is
in its use. If there's a real issue, it's with people
and their knowledge of process documentation.
It's _not_ the tool itself as you stated.
prev parent reply other threads:[~2023-07-25 21:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 1:46 Lin Ma
2023-07-24 21:29 ` Victor Nogueira
2023-07-24 23:02 ` Jakub Kicinski
2023-07-25 0:15 ` Lin Ma
2023-07-25 0:56 ` Jakub Kicinski
2023-07-25 1:33 ` Lin Ma
2023-07-25 3:59 ` Joe Perches
2023-07-25 19:38 ` Jakub Kicinski
2023-07-25 19:50 ` Joe Perches
2023-07-25 19:56 ` Jakub Kicinski
2023-07-25 21:04 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27446992c6fcc982a26085151988f7be3aa1e3d7.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linma@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®