From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9005548695F for ; Thu, 8 Jan 2026 14:38:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767883117; cv=none; b=LO0yyEMMMwshzlhPtffvln8X3zCvdh1GxJ5UfkPizxCzEu8Q5QFaTD9fd5eaTy/7cOCLToiKt53K7qQKJdwMR9MIaXi8Tr4OVC9fDY5q7ob9xt5nliPtA/rQDvpHNvE38Gx4LuyysHipe12tPU/iLSSpLKwIASGRy1WvIvLrz4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767883117; c=relaxed/simple; bh=p+WpUe61Uf/9zsVuhMKn5/zWYHwkJX9Z0uAkX0tmoM0=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=rLfZ79Ihjda5PGOmUWnmSwvuwnBja2oEhZP7nZXT+qHADscLXIye+GMCRK0MHXAv4uNIRhIjnW4Q0g6JAwK+qNphfYX1kR4ut9xR27QfJuZgfLcGrlp+2mE96xGoo7IUs8BzVR8bI1KDo2dubIM7bde+z06j86ePwZIrNu8FbT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Cx8jHBf0; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Cx8jHBf0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767883115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XLV+b8wRoDeQA2Nas8F4iCfGEiK/r85r+1LvNr8tJ1Y=; b=Cx8jHBf0+WP0dZUiMwGvQtyZkpCa7AWNVk5eT5c5YhHcPabNlbh5xo97LK++aOeSsBDP8o dl3/1VnJanlFKFrE6cJqdPIL1tMTQfsJNwo9Pnv9ZnZLb402MCBjVE8jNTB7KHZPvoXRKx mljf8XLNO1/0IPxspKDfofX5hzk/Lv0= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-264-96nE0lGHMHWWZwJmSEH8kQ-1; Thu, 08 Jan 2026 09:38:30 -0500 X-MC-Unique: 96nE0lGHMHWWZwJmSEH8kQ-1 X-Mimecast-MFC-AGG-ID: 96nE0lGHMHWWZwJmSEH8kQ_1767883108 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CA09219560AA; Thu, 8 Jan 2026 14:38:27 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.4]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 47A2130002D1; Thu, 8 Jan 2026 14:38:21 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20260106080251.GD2630@sol> References: <20260106080251.GD2630@sol> <20260105152145.1801972-1-dhowells@redhat.com> <20260105152145.1801972-4-dhowells@redhat.com> To: Eric Biggers , Herbert Xu Cc: dhowells@redhat.com, Lukas Wunner , Ignat Korchagin , Jarkko Sakkinen , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , "Jason A . Donenfeld" , Ard Biesheuvel , Stephan Mueller , linux-crypto@vger.kernel.org, keyrings@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 3/8] pkcs7, x509: Add ML-DSA support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2745002.1767883099.1@warthog.procyon.org.uk> Date: Thu, 08 Jan 2026 14:38:19 +0000 Message-ID: <2745003.1767883099@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Eric Biggers wrote: > > 1.) If the CMS object doesn't include signed attributes, then it's a > digest of the real message the caller provided. Yeah - that needs fixing, but I need to be able to test it. openssl-4.0 (at least that's what appears to be on the master branch) will have a fix for ML-DSA CMS_NOATTR support (it was committed in November), but it's not available yet unless you want to build your own. sign-file would would normally use CMS_NOATTR, and this is worked round by patch 4 in this series by using signed attributes for ML_DSA. David