From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E0E4C4167B for ; Wed, 29 Nov 2023 20:35:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234003AbjK2UfI (ORCPT ); Wed, 29 Nov 2023 15:35:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231489AbjK2UfG (ORCPT ); Wed, 29 Nov 2023 15:35:06 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A704A91 for ; Wed, 29 Nov 2023 12:35:12 -0800 (PST) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1r8RH1-0006ZB-Pk; Wed, 29 Nov 2023 21:35:07 +0100 Message-ID: <2746082e-4357-4608-8fd9-ffbd1ecd6ac2@pengutronix.de> Date: Wed, 29 Nov 2023 21:35:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/2] arm64: boot: Support Flat Image Tree Content-Language: en-US To: Simon Glass Cc: linux-arm-kernel@lists.infradead.org, Masahiro Yamada , Tom Rini , lkml , U-Boot Mailing List , Catalin Marinas , Nathan Chancellor , Nick Terrell , Nicolas Schier , Will Deacon , linux-kbuild@vger.kernel.org, Pengutronix Kernel Team References: <20231129172200.430674-1-sjg@chromium.org> <20231129172200.430674-3-sjg@chromium.org> <03595817-4698-46d3-b2d8-3bc40c7e723e@pengutronix.de> From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Simon, On 29.11.23 20:00, Simon Glass wrote: > On Wed, 29 Nov 2023 at 11:35, Ahmad Fatoum wrote: >> Doesn't hardcoding a load address and entry address here defeat the point >> of having FIT as generic portable image format? >> >> At least barebox will try to place the kernel image at physical address 0 and >> will exit with an error message if no SDRAM is located at that address. >> The recommendation in that case is to omit load and entry address altogether >> to have barebox find a suitable location, but I see now that the FIT specification >> requires a load and entry address. What would happen if U-Boot tries to load this >> FIT image on a board that has no DRAM at address 0? > > The 'kernel_noload' type indicates that the load/exec address are ignored. Can the script not insert load/exec addresses with dummy values to avoid confusion? >> Please Cc me on subsequent revisions. I am interested in testing that this works for barebox >> too. > > There has been some discussion about this recently in U-Boot too, > along with a series [1] which you could try if you like. Thanks for the pointer. I have just sent out a first patch to add support for kernel_noload to the barebox mailing list[1]. With that change applied, barebox can boot the FIT images generated by this series. Once that's accepted, I'll reply with a Tested-by. [1]: https://lore.barebox.org/barebox/20231129203106.2417486-1-a.fatoum@pengutronix.de/T/#u > The FIT spec[2] does not provide enough detail on exactly what > kernel_noload means and we should improve this at some point. Yes, that would be nice. Also straight references to e.g. U-Boot configuration symbols could use some rewording. Thanks, Ahmad > > Regards, > Simon > > [1] https://patchwork.ozlabs.org/project/uboot/list/?series=382849 > [2] https://github.com/open-source-firmware/flat-image-tree > > > >> >> Thanks, >> Ahmad >> >> -- >> Pengutronix e.K. | | >> Steuerwalder Str. 21 | http://www.pengutronix.de/ | >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |