From: "Kumar, Udit" <u-kumar1@ti.com>
To: Siddharth Vadapalli <s-vadapalli@ti.com>,
<peter.ujfalusi@gmail.com>, <vkoul@kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <vigneshr@ti.com>,
<srk@ti.com>
Subject: Re: [PATCH] soc: ti: k3-ringacc: include platform_device header
Date: Fri, 7 Feb 2025 19:45:48 +0530 [thread overview]
Message-ID: <274838d7-08e5-4e09-b872-47644b96a219@ti.com> (raw)
In-Reply-To: <20250207065123.879863-1-s-vadapalli@ti.com>
Thanks for fix Siddharth
On 2/7/2025 12:21 PM, Siddharth Vadapalli wrote:
> Users of "k3-ringacc" APIs may not necessarily be platform devices. Such
> users therefore will not include "platform_device.h", resulting in
> compilation warnings for the APIs declared in "k3-ringacc.h" which assume
> inclusion of "platform_device.h" by its users.
>
> Fix the compilation warnings by including the "platform_device" header
> file, which should ideally have been included since commit under Fixes.
>
> Fixes: d782298c6f6b ("soc: ti: k3-ringacc: add AM64 DMA rings support.")
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> ---
>
> Hello,
>
> This patch is based on commit
> bb066fe812d6 Merge tag 'pci-v6.14-fixes-2' of git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci
> of Mainline Linux.
>
> Regards,
> Siddharth.
>
> include/linux/soc/ti/k3-ringacc.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/soc/ti/k3-ringacc.h b/include/linux/soc/ti/k3-ringacc.h
> index 39b022b92598..6bbb58068048 100644
> --- a/include/linux/soc/ti/k3-ringacc.h
> +++ b/include/linux/soc/ti/k3-ringacc.h
> @@ -8,6 +8,7 @@
> #ifndef __SOC_TI_K3_RINGACC_API_H_
> #define __SOC_TI_K3_RINGACC_API_H_
>
> +#include <linux/platform_device.h>
> #include <linux/types.h>
>
Reviewed-by: Udit Kumar <u-kumar1@ti.com>
> struct device_node;
prev parent reply other threads:[~2025-02-07 14:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 6:51 Siddharth Vadapalli
2025-02-07 14:15 ` Kumar, Udit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=274838d7-08e5-4e09-b872-47644b96a219@ti.com \
--to=u-kumar1@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@gmail.com \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®