From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759164AbdJRDnX convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Tue, 17 Oct 2017 23:43:23 -0400
Received: from mga14.intel.com ([192.55.52.115]:15232 "EHLO mga14.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1756990AbdJRDnV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 17 Oct 2017 23:43:21 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,394,1503385200"; 
   d="scan'208";a="1325191"
From: "Dilger, Andreas" <andreas.dilger@intel.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
CC: "Drokin, Oleg" <oleg.drokin@intel.com>,
        James Simmons <jsimmons@infradead.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Lustre Development List <lustre-devel@lists.lustre.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 18/20] staging: lustre: osc: mark expected switch
 fall-through
Thread-Topic: [PATCH 18/20] staging: lustre: osc: mark expected switch
 fall-through
Thread-Index: AQHTQ3WrkbAIpLbZVE6sVgS8oQ7v/KLpJr+A
Date: Tue, 17 Oct 2017 23:03:36 +0000
Message-ID: <274B25B3-8F82-4DDA-87F9-419C7F3BC510@intel.com>
References: <cover.1507781178.git.garsilva@embeddedor.com>
 <ed0b43170d08cda14de2b6a8069e77054b03fae0.1507781178.git.garsilva@embeddedor.com>
In-Reply-To: <ed0b43170d08cda14de2b6a8069e77054b03fae0.1507781178.git.garsilva@embeddedor.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.252.142.85]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F632F47AE254BE43A05CC98314D4C077@intel.com>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Oct 12, 2017, at 10:17, Gustavo A. R. Silva <garsilva@embeddedor.com> wrote:
> 
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Addresses-Coverity-ID: 1077598
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>

> ---
> drivers/staging/lustre/lustre/osc/osc_cache.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/lustre/lustre/osc/osc_cache.c b/drivers/staging/lustre/lustre/osc/osc_cache.c
> index e1207c2..eab7759 100644
> --- a/drivers/staging/lustre/lustre/osc/osc_cache.c
> +++ b/drivers/staging/lustre/lustre/osc/osc_cache.c
> @@ -227,6 +227,7 @@ static int osc_extent_sanity_check0(struct osc_extent *ext,
> 			rc = 65;
> 			goto out;
> 		}
> +		/* fall through */
> 	default:
> 		if (atomic_read(&ext->oe_users) > 0) {
> 			rc = 70;
> -- 
> 2.7.4
> 

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation