From: Mark Brown <broonie@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Bjorn Andersson <andersson@kernel.org>
Subject: Re: [PATCH] regmap: Check for register readability before checking cache during read
Date: Thu, 15 Jun 2023 21:55:05 +0100 [thread overview]
Message-ID: <274a7a7c-ca6c-44fe-8f7a-e19aaf86a86a@sirena.org.uk> (raw)
In-Reply-To: <ea63420a-a08d-3610-b01f-61dabe56d2df@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Thu, Jun 15, 2023 at 10:45:53PM +0200, Konrad Dybcio wrote:
> On 13.06.2023 22:07, Mark Brown wrote:
> > Ensure that we don't return a spurious cache hit for unreadable registers
> > (eg, with the flat cache which doesn't understand sparseness) by checking
> > for readability before we do a cache lookup.
> this patch breaks using regmap_field_force_write() on fields that are
> parts of registers marked as write-only (e.g. by regmap_access_table.no_ranges)
> Is that intended?
> What's the recommended fix?
Ugh, let's just drop it - it's just an optimisation.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-06-15 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 20:07 Mark Brown
2023-06-14 13:47 ` Mark Brown
2023-06-15 20:45 ` Konrad Dybcio
2023-06-15 20:55 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=274a7a7c-ca6c-44fe-8f7a-e19aaf86a86a@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®