From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CED16B672 for ; Fri, 12 Sep 2025 08:46:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757666790; cv=none; b=NK8P75dWx/i/NskpDFsoN7U0sBtYS3xErChtvEpXnWk3pfCqCedLOb8ly0sMDq5CThgv0sN/C61ONKH8300Xupjj8wT38/T1wY2gF0XjspS64hDL02xQDvdAMRXwZin4ONv2iIa2G60BDtUL4E3OggEc2ccfwZq0E+M+If5TVLk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757666790; c=relaxed/simple; bh=6I3jhfnsNBLk7YU/g7sGdlA5ruh8eM1vlY/iO+dFdTQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=txKPphyUzz/Wackseo40NabDYnge0ZHKMzQBA02am0tljDeHZLhpRLU9uBaL4SKNq6s/E0KZWPX0bcrNgOCQrzpEP7qJQUJBwmNVidneQIYNaCPYQOlU+d62pU+DYQPXwCYVZKqV1b7hvfenhdxACRfvfGG0q0b1OLt/jLWnVA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EGkDy38r; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EGkDy38r" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58C71ogO025747 for ; Fri, 12 Sep 2025 08:46:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lGDrGSwQe5Wxsvo3kpmlzGmuY1iFtGQeQKswsFIUacE=; b=EGkDy38rYrnjaKFW 5EWhmMA0KGDcOE5BcF6+mohdOrto8vCfS0ZsLlPcGzGjvyjjFExh3s665KxQ5Kfv 7keM2U5DyWmGO1hfmLY1tpbCn6jkw3YjiF2pqc9eU59reSEAN7Uo/HSC2GFlcnyH ugju1T8lvtHcRBLmNTwEyMyjC2hmNjRPrLSU+4d5xHWxJjYdcqzLCvh5iMrERuge puJUZB/mpPQjhXCRVLZjTPTIutQ1hyuq8p9agGlSZ0chJt8WkGakoQVd+LWjpTbF bK+D054z+d2HDhLcNEDFqx8SS/xGdHJ2M/zKo8HtG5IytIX/zIxvxaNHf7/JPO5t WejYQw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 490cj12u8w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 12 Sep 2025 08:46:27 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4b5f92a6936so5287191cf.3 for ; Fri, 12 Sep 2025 01:46:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757666787; x=1758271587; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lGDrGSwQe5Wxsvo3kpmlzGmuY1iFtGQeQKswsFIUacE=; b=TdVBdvqnvRnYod01Xafayp1xnZZLdXxDK62jKGcCLm5ByFL9fjKW8wzN4a5nfRAtGo 3S+4Scu8p3s0fjZQ7LsUVPbiGjXOXbFjCGB+HQ12M83RpcwIAa0L/NTSSsjxIY2NtlYw sSZs6Bsqm9ATvpWgFADovWlIwhfZSMbvxrnbwUFKXeMFti/JvrD9YrynB/vIPJYTpgPT eTckK6uT0/3XxEJ3XVkb4+NnBNAOC6yYi7Fc+U8lWZhYdN+0l+MwhSrpkuso5YslVGx2 POjrCattEwX7nEL/E62KV6WIkKYUpcMUxZKdW6CML94OsmwdvQL608G1tOC+6ZfAcz57 X//w== X-Forwarded-Encrypted: i=1; AJvYcCVAcO0coAuo38qhBr/cFNYKl/UuzLf1s7RZs0wfdznTbfIvVTWHAD951vAUNEquZGZeE1zHwteah9GUOXs=@vger.kernel.org X-Gm-Message-State: AOJu0YyXakhGcBhK643AM4lAR8KC+UTkVe+rRqPW0qZhp0M2DbaF0ZZm 6QQMKfBLFiiyXZafGSHuvOicy6CXw/J2mG0LgDBlFuPDOlAWrSxi20rvbP8cdNDYi8GnQ3gN090 ztq6U2o8xJndE38+wyXvzL0zwoloDRgJeg6n8MD3KZWkIrsoOX7yk5uVmziIwqlP9kts= X-Gm-Gg: ASbGncsMxQDaH1d0106Q+Wz64VfKw5wBxw+22z3DU9WTT6a3pyswiVBHFOdzD2FpCBE HvtI2FGfPWDlWDtDeQmEr8lluQY5tIq8uWAPPdb0z4eP9m4kIgjYZHlyKKwoOg/WIVVN+swyzdU aUzoHCsOSc58lh4gU9XzkOzzZBzOALUwYlTre+rgnNLisRq9xJ2jmVPuqFkFaHBXagV44uAgVf9 nk32WTimtf0BVRwcAMjxVwmrMh3kd0hDdsR94Hahp9XQAT3yOel9xKejdGCjiRWu/4yBETazY3h Yf4wKc2pK5GeSbdrZNvLay/OCk2E0nCsNnYyhfl4MsjJwB5GX4snGNJs1cWUUJ+zMIvMb4aKxkI SswyFdqqm52EMjDBFRVgxRA== X-Received: by 2002:a05:622a:5ca:b0:4b5:d60c:3f33 with SMTP id d75a77b69052e-4b77d13a75cmr17660131cf.13.1757666786803; Fri, 12 Sep 2025 01:46:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+NVmc9TA9PDMivtFQF3GWnTURuIOA8rik1NCbnbvalHLcjpoipS/fO2pMicU4DnVEo5yPGA== X-Received: by 2002:a05:622a:5ca:b0:4b5:d60c:3f33 with SMTP id d75a77b69052e-4b77d13a75cmr17659811cf.13.1757666786285; Fri, 12 Sep 2025 01:46:26 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b07c337e785sm150379466b.25.2025.09.12.01.46.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 01:46:25 -0700 (PDT) Message-ID: <274b27e6-ef43-4597-a7d6-1f948f2e6c5b@oss.qualcomm.com> Date: Fri, 12 Sep 2025 10:46:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 04/13] phy: qcom: qmp-usbc: Add QCS615 DP PHY configuration and init data To: Xiangxu Yin , Dmitry Baryshkov Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, fange.zhang@oss.qualcomm.com, yongxing.mou@oss.qualcomm.com, li.liu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, Bjorn Andersson , Konrad Dybcio References: <20250911-add-displayport-support-for-qcs615-platform-v4-0-2702bdda14ed@oss.qualcomm.com> <20250911-add-displayport-support-for-qcs615-platform-v4-4-2702bdda14ed@oss.qualcomm.com> <3ihzpsmf3btzeltxggdnbheji6bdeornravua76adw5dhotztu@e3fca2prl45r> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: qlSjyM4H1d0hCNT_H5oLnDRyg6jtey1R X-Proofpoint-GUID: qlSjyM4H1d0hCNT_H5oLnDRyg6jtey1R X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTA2MDAyNCBTYWx0ZWRfX5o5/bYAb6KMR p4l1tFNPhNRCMpc1Tz2I2RjjgGYERVnt35SC0kazOa5JAZrMBVYAMqcOitZAVe5cquFuTkBCBQO m+8N5tXOyrD60npc9+d1/dA2Zm5AdEyaSgblrwISNP186Jo0PdfVereKgaYcmrTku8dyW8ad1LJ j7T3qbp336eixXSoiSkzYGz5H/m8hxRsuXJvjVy6jusSf3oDkhyj0wPoxCxJTsO3tQw5wPa2MAF 3B7pt7glQpqEF/gtdujTPa/Z2ILzwWJ0VyaRPAU6FoROcCsq/7snDHYbLbpmISr3+S6oEJ+CNAy n3M2mRc7XivLdGPrA2uP4CwnjO2CpY5BrcC/UpLO0ssJi1gGOAI/eJlc9qyIYx/iEcRo/yKEy3x GRVoz4LI X-Authority-Analysis: v=2.4 cv=QeFmvtbv c=1 sm=1 tr=0 ts=68c3dde3 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=Y7PaXT35z5vDV90y7_UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-12_03,2025-09-11_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 clxscore=1015 spamscore=0 impostorscore=0 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509060024 On 9/12/25 4:15 AM, Xiangxu Yin wrote: > > On 9/12/2025 9:24 AM, Dmitry Baryshkov wrote: >> On Thu, Sep 11, 2025 at 10:55:01PM +0800, Xiangxu Yin wrote: >>> Introduce QCS615 hardware-specific configuration for DP PHY mode, >>> including register offsets, initialization tables, voltage swing >>> and pre-emphasis settings. >>> >>> Add qcs615-qmp-usb3-dp-phy compatible string to associate QCS615 >>> platform with its USB/DP switchable PHY configuration. >> This should be the last patch in the series: once you add the compatible >> string, it is expected that it works. >> >> The patch LGTM. > > > In v3[12/14], the compatible string was placed in the last, and you remind me > will trigger unused warnings for the earlier-defined qcs615_usb3dp_phy_cfg. > So I merged them in v4.  The intention is that you can do all the preparing first (which doesn't need to include an assignment to e.g. DP tables, since the code operates on a pointer if it's non-null), and you can push all the platform additions at the end (both tables and compatible in one patch) Konrad > > If move this patch to the end, patch v4[07/13] will hit unused warnings due to > missing references. Should I squash patches 04 & 07 and move them to the end? > I'm concerned the resulting patch might be too large. > > >>> Signed-off-by: Xiangxu Yin >>> --- >>> drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 141 +++++++++++++++++++++++++++++++ >>> 1 file changed, 141 insertions(+) >>> >