mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ming-Jen Chen <mjchen0829@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-input@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com,
	arnd@arndb.de, peng.fan@nxp.com, conor+dt@kernel.org,
	krzk+dt@kernel.org, robh@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v4 2/2] dt-bindings: input: Add Nuvoton MA35D1 keypad
Date: Tue, 10 Dec 2024 13:23:39 +0800	[thread overview]
Message-ID: <274c7ba7-dd7a-4981-95a8-38ed953a7dbc@gmail.com> (raw)
In-Reply-To: <2a47hwrbl3r6h5umwikt7bd7rp3njj6wnlo5e67f5kl6zhaq7g@cnolynoswb37>



On 2024/12/4 下午 03:49, Krzysztof Kozlowski wrote:
> On Wed, Dec 04, 2024 at 02:10:14AM +0000, Ming-Jen Chen wrote:
>> Add YAML bindings for MA35D1 SoC keypad.
>>
>> Signed-off-by: Ming-Jen Chen <mjchen0829@gmail.com>
> 
> 
> Repeating same comment third or fourth time is a waste of my time.
> 
> NAK.
> 
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.
> 
> Best regards,
> Krzysztof
> 

I will carefully review the v3 discussion thread to ensure that all
feedback is properly implemented. Once I’ve addressed the issues, I’d
like to confirm the next steps with you:

1. Should I drop v4 entirely and submit a revised patch as v5?
2. Alternatively, would you prefer me to resend v4 with the necessary
corrections?

Please let me know your preference so I can proceed accordingly and
ensure a smoother review process.

Thank you again for your guidance and understanding.

Best regards,
Ming-Jen Chen





      reply	other threads:[~2024-12-10  5:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-04  2:10 [PATCH v4 0/2] Add support for nuvoton ma35d1 keypad controller Ming-Jen Chen
2024-12-04  2:10 ` [PATCH v4 1/2] input: keypad: add new keypad driver for MA35D1 Ming-Jen Chen
2024-12-04 14:48   ` kernel test robot
2024-12-04 17:13   ` kernel test robot
2024-12-04  2:10 ` [PATCH v4 2/2] dt-bindings: input: Add Nuvoton MA35D1 keypad Ming-Jen Chen
2024-12-04  7:49   ` Krzysztof Kozlowski
2024-12-10  5:23     ` Ming-Jen Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=274c7ba7-dd7a-4981-95a8-38ed953a7dbc@gmail.com \
    --to=mjchen0829@gmail.com \
    --cc=arnd@arndb.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®