From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCB21416D01 for ; Mon, 29 Jun 2026 14:31:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782743518; cv=none; b=F95dfB0XsIz/0YANV4z+v2sRcGnAlXRlzvSw8RJiYAhxoGZeQSlC5XQ43Su4Zo9lykPJMGLUiXEGn+ZpVGFAs4rjZkhDWy21bbiGXKrzgx2ZudBVh4CjlM+GgAbzCtrfMhJQaodY+bV2hhVEV6C58z4d7kUabUON6DEMG79zGfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782743518; c=relaxed/simple; bh=0XCB7De3/3UmkyRVbH9S/Q+7qzzvs8n4+HeLrSIM4rY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EfwjLum+bt0vYofBCABr9Kc40HEfEZRAXm1AP5N+2/0bcZwDdh5Z71Ij7g10qpnw1pvwAwIYgkUmQg6uWCKE6IiSPyImikvTMwiCiCXsX3r0zpJ5RWr4OasBHw/qgJ6IG9C2+t10WqM+zyIZvYMwY0RkxwSvC5hvwcjuBDO3wXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fVGZiIbo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=J5FIdkXZ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fVGZiIbo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="J5FIdkXZ" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65TASp2X2601110 for ; Mon, 29 Jun 2026 14:31:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MYh7cIP72DN2R7IDyMw5swr101H9ibCpywVjfyuBqxQ=; b=fVGZiIboijZ6fTYw suniisXUBIqPqHJ125RaQHLiysKolr3+rGP5YxBt7WAK9bajjPCjkWPTjxqAxPmj tdYAhes6KJBXRQ7PyT57dkkPPN3aM/KR8DLrSzvVvfCXREtagSEvi/RBCYEeCdiB OkEHmc36ytSYbzeSB9ZP1gaUYa5TW3ZzFokKegQFOBo5bSquxCQzsk+nnyGy8S09 dchZGoBGK/qFJR9Zs6RY5hcxfkJXjUzsz46qlh3DAwBmreELanSCg+5i/FTGSfRh xSItycfN6JKPW3THNIj+eCAo6FLOxFLhj7vKG4uSOn2kHkZ4ocv8dpLq0w0YREqT R57MRQ== Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3nnw9adp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 14:31:56 +0000 (GMT) Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-6a1791a6281so974857eaf.2 for ; Mon, 29 Jun 2026 07:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782743515; x=1783348315; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MYh7cIP72DN2R7IDyMw5swr101H9ibCpywVjfyuBqxQ=; b=J5FIdkXZNGUp1qyvsYrbHOLUUAjsnga6plX30hUBUKjN3d8tbUAYYdRswTidt2ycMQ 4UIB6vVUhxhOGu6MHzB3GC6SLS2iO1tO2d2ibbFiH9WwcK60Bx+cT+XwoxZRdkQAMpvI WZ1JSLKKWZ8tdqbCCFC7dSSaigpqEwdzzFCgKW724fmVzgMEkZRIKFBrwDeieuqZ6gVQ N4fbWvkxR/CKX0sIpGNsRVWSommIHp0+0rX1n3L1Joygc0GLNKu7x/crk9aAmqOlSCmF KIjj630sNyKCUDMfe9UQz9sfprSCKqndrCGCNfmXeld2PmnAjDmG3jvphgqyMMAqeI6m 4WJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782743515; x=1783348315; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MYh7cIP72DN2R7IDyMw5swr101H9ibCpywVjfyuBqxQ=; b=MZRbSgybztTZrRSE717zKxQ/XJ+AFggyUC9CQC72rEUeatjx/3Xz5jpF+DGo049i3f k1fAD/+Ic+OzW1iMKBGKadImPhgSJZu7pOSS+cAXkx9V38hyH5iid8cZPkmnOKmnd8hf PmcMU5V7hl9e1t9PN6yNj7gF81HCra8RKVrv10xWrVgt7OhuiJCIY0xRYQtHQRl7oLpa eXxL1FiliwXdJjtriJ3SVch18QJvUkDEgiPXBJRHySb4sprrEtJXLBaCxsC5AFxFvvg7 fQZiOAvGTyKivcS2nKkK+fWjoKj541VPHmM4qJ1JNZQ+MPdZ2txyXX4mW332ppdVQv00 xg2w== X-Forwarded-Encrypted: i=1; AFNElJ/5NEo3oTBoXqOlrMnKqhgauzQo5597eZLfTXDeOkTNnvkvgBeParMm+Cp7HzSLs7G8A0c3eRbBRTokovE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw07Wu5J8MpYXSPIz3QUJpH6H1fiK5Efx3B77ZpbI2FdzWRcYYF UJu0bxrMdjspn60Bh5trg8LORCn4v2PQg7reTit3dGbjxxqG/xnFHZHpzipllJxhAhjOaNykkMu WKHp8yAGaMGpTQSGvsTxc8LwkZJMtNcx+/QXoUr50Ul0MI5t4w28ktD6bdMZ9GPNOnzw= X-Gm-Gg: AfdE7cl6bq1zRnpAu4ybzhqi7gGEWWLQrTYLn9r1ySZyLEV2H8+ageOII0bp8/IkoxG WsOLgaqQg2mkD4h26E8CNG4v++u7ee0vq7s2Xd5OgFN9YBvMUTKAZmx8mW3eqgtpvG7geoArdve weLe6hui0ScwH0EQOUbusD1d31Gvb0F3v5k/9//K5Z0bZCNPq12F+5DuIwTESyEQmJWAKtaIgRW H0T8bpmbNMwZAR0lAQLD+/DbRU/t5ywIeVSmYHd3ru5NeG/W3RA9ifQnbk1awSB0N8sDPpfMys6 3Ooiba3UvUfe0D2G2U6SYxJueNouAqhIAwiIEhExHVH/QUm61W1mbdZZCR/aJOgrea3XDh5sVMq p752Zqb1CAjZSHmo5znN4hToAvqwPqlsj0uNloXHCqA== X-Received: by 2002:a05:6820:1c86:b0:6a1:4e5a:e642 with SMTP id 006d021491bc7-6a14e5ae9b4mr7017866eaf.2.1782743515264; Mon, 29 Jun 2026 07:31:55 -0700 (PDT) X-Received: by 2002:a05:6820:1c86:b0:6a1:4e5a:e642 with SMTP id 006d021491bc7-6a14e5ae9b4mr7017835eaf.2.1782743514691; Mon, 29 Jun 2026 07:31:54 -0700 (PDT) Received: from [192.168.1.13] ([106.222.231.34]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4472f0464a6sm21209882fac.15.2026.06.29.07.31.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 07:31:53 -0700 (PDT) Message-ID: <2754f738-04ef-4f54-86bb-6744e768a8ad@oss.qualcomm.com> Date: Mon, 29 Jun 2026 20:01:43 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/8] dt-bindings: remoteproc: qcom,pas: add thermal mitigation properties To: Daniel Lezcano , Krzysztof Kozlowski Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Amit Kucheria , Manivannan Sadhasivam , Konrad Dybcio , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Manaf Meethalavalappu Pallikunhi , Dmitry Baryshkov References: <20260609-qmi-tmd-v3-0-291a2ff4c634@oss.qualcomm.com> <20260609-qmi-tmd-v3-1-291a2ff4c634@oss.qualcomm.com> <20260610-ocelot-of-stimulating-excellence-bcb0fe@quoll> <03d863ee-2caa-41f2-94b5-7332fc930b42@oss.qualcomm.com> <7f1e46fb-15e3-4638-9930-8abc1dd5a778@oss.qualcomm.com> <3cbcaf8c-357e-42d2-91c1-9d1a32c55ed0@oss.qualcomm.com> <9a31bb29-75d7-42fa-b8a8-4155cf85cadf@oss.qualcomm.com> <61765401-3397-497d-a0ca-e9bf9d76cc6a@oss.qualcomm.com> <5b0f1f39-ddaa-4a2e-ab29-34aacc9ff672@kernel.org> Content-Language: en-US From: Gaurav Kohli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDEyMCBTYWx0ZWRfX83GPzzNp5IpL X7+/42uDiO0nNIm4yUl7f+y8/O7aYtmEwgGk4SgjqO6M8+eUhVAgeIATwoYVG7lRjmkeQmAlGOc wfS+P6n/rBeZ2+sl5qDK4fjpblAhwnI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDEyMCBTYWx0ZWRfX5/pTW5YKXMjn Bwe4lfFl0SgVpD2iM3RRm4qH7n3KtjnZGaQaoRHZKekBiA1h+Ks57n1VZ38nr2QFaaAM7Lci2b1 NHHrzww4DmTnDbN5LOjaNST+SoMsKJJfuIwB+AFRcYBpkx3du8eygy5FUCX6bgjEWi/4cS3scmH ZhaYrRWWA7opMkqa69QIqWq8cmsv2VujZoOkeM6X1WtKsu4qxph+pOEZ0GnaGtZdnPcMEqtKjZs wTEJAhHpoAJzo5yygMJ3OVylvCa5zQezJXW4pH8ZU71BMEFkDGl7R2HAsA2FIiA1iAKn+Kp/wjx IOMdxSgBX/DZ/nbBehUtw7GWIhFVjwtGSdtOsU/GBHgJJ3g++daJZE+tIWelxTbwch5wh9xog69 MxCLeo32+To+K2YpjTVZ6/lNo7lpMTLoPlV01IEZ1GoMfqKCOW3fSsxQ+0ZZUnOmUB5GonAJlNr uu4WenAMPzl6mdMWJ/A== X-Proofpoint-GUID: Pm6a4n5aAjNZuGd8-6R92CP8zEAlIknb X-Authority-Analysis: v=2.4 cv=cefiaHDM c=1 sm=1 tr=0 ts=6a4281dc cx=c_pps a=lVi5GcDxkcJcfCmEjVJoaw==:117 a=JaHktJlP2QtFIg7UHuVw+g==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=p2ZdXy1_vrHN-z_H-RIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rBiNkAWo9uy_4UTK5NWh:22 X-Proofpoint-ORIG-GUID: Pm6a4n5aAjNZuGd8-6R92CP8zEAlIknb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290120 On 6/25/2026 1:21 PM, Daniel Lezcano wrote: > > > Le 25/06/2026 à 08:48, Krzysztof Kozlowski a écrit : >> On 24/06/2026 17:56, Daniel Lezcano wrote: >>> On 6/24/26 12:42, Krzysztof Kozlowski wrote: >>> >>> [ ... ] >>> >>>> Therefore I still do not see the need of tmd-names. You know the >>>> name of >>>> cooling device, because you have strict one-to-one mapping. >>> >>> >>> There is one remote proc with one or multiple cooling devices attached. >>> >>> We describe those in the remoteproc node with the tmd-names. >>> >>> Anyway, we should be able to list the tmd names in the driver itself if >>> we ensure a consistency with the index by defining them in a shared >>> header eg. include/dt-bindings/firmware/qcom,cdsp.h >>> >>> #define HAMOA_TMD_CDSP_SW 0 >>> #define HAMOA_TMD_CDSP_HW 1 >>> #define HAMOA_TMD_CP0UV_RESTRICTION_COLD 2 >>> >>> In the driver: >>> >>> struct tmd_name { >>>     const char *name; >>>     int id; >>>     bool disabled; >>> }; >>> >>> static struct tmd_name tmd_names[] = { >>>     { .name = "cdsp_sw", HAMOA_TMD_CDSP_SW }, >>>     { .name = "cdsp_hw", HAMOA_TMD_CDSP_HW, .disabled = true }, >>>     { .name = "cpuv_restriction_cold", HAMOA_TMD_CP0UV_RESTRICTION_COLD, >>> .disabled = true }, >>> }; >>> >>> ... >>>     for (int i = 0; i < ARRAY_SIZE(tmd_names); i++) { >>> >>>         if (tmd_names[i].disabled) >>>             continue; >>>         devm_cooling_of_device_register(rprocdev, >>>             tmd_names[i].name, tmd_names[i].id, ...); >>>     } >>> >>> >>> In the device tree: >>> >>>     cooling-maps = <&rproc HAMOA_TMD_CDSP_SW min max>; >>> >>> I think that is somehow what Konrad and Dmitry were suggesting >>> >>> Does it sound better ? >> >> Yes and I am surprised that it came now. So you had TMD index available >> thus the ID was defined. If device has unique and fixed ID, you should >> not have any more properties defining it, because that ID is enough. Any >> names could be only for users, e.g. label, but that is not the case here. > Yes indeed, having the constraint of cooling index and tmd(name, id) for > the connection between the cooling device and the thermal zone was a bit > confusing in our discussion. > Thanks for review, will send new version with this new dt binding approach. > Thanks for the review >