From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754242AbbIIJB4 (ORCPT ); Wed, 9 Sep 2015 05:01:56 -0400 Received: from mout.web.de ([212.227.17.11]:56021 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209AbbIIJBq (ORCPT ); Wed, 9 Sep 2015 05:01:46 -0400 From: Alexander Stein To: linux-rpi-kernel@lists.infradead.org Cc: Eric Anholt , kernel@martin.sperl.org, Stephen Warren , Lee Jones , Russell King , Mark Brown , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/6] bcm2835: auxiliar device support for spi Date: Wed, 09 Sep 2015 11:00:43 +0200 Message-ID: <2757852.TDqE8OEVr2@ws-stein> User-Agent: KMail/4.14.8 (Linux/4.0.5-gentoo; KDE/4.14.8; x86_64; ; ) In-Reply-To: <87h9n4weg8.fsf@eliezer.anholt.net> References: <1441359711-2800-1-git-send-email-kernel@martin.sperl.org> <87h9n4weg8.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:52IvKkIYxrP+zojRYsPZiy+w2S/OXxZd/LtJFatoGrnPesPoxDD 7jED6T7GMcnWYt0S+tISe5ObEp6ehSGqcbYO9EQIC+Wt5zoBBmGBTqXNxqAvNxm3NV42EAa Y4RxrzUl2/0nJr6xWvoqHybFbxbR3IQXBuGKOjRbaPZir4IbomJGHTzuWvznzYn8bw30K+5 aWzFVQeeeTFy94/W94Afg== X-UI-Out-Filterresults: notjunk:1;V01:K0:5IYWDMJs8Lg=:fq3bbSHvFD7yIOYc9cFo68 XxJltTaGEqhd5OhDCh8kLVvtsS51NyozwjVDfDFNkqk0zrqjZrdIm8mKoCr1pa7Ah9ghjoB/A DwooeoJIR7/eOPk62qZWLhtH4ZvJVHy3jP9hMH6uvG4dRXxDNtVFmY50GxMXzKV3scg9rAGJL AFzSz5xlnXgn4ghUo2oW4PdC3u5+Bk4RMdBdQQWo/d5Ueno+SztgOAYivdzTp+mk0rJ0fz1bo wLY85cCfN+fHQpBXRYH+IGQF9F/PXDVk8izF+cohkSncrQBhkDsRzQGVfz7N+k0Zq7MESoMio iB/TMFOyorB5yFM/wJZnsuUwxei97unIHOJFUunaIY56rg2DVfKtO9z4n8l8F6/89igdl16Fg 3B7EyXlYGQEKx0JrRnkM1fyFuzTa3+dGMqFlqBkwf13yvd+0jGmDPIEtNL567P1QgHJA+WNyR MvRw2LoQWDsCSrydxcEpiYrafTYYBNeEDAYY/HIp8Ew2MrkKFbglevlN+7WeaTYXRGM+kMQVc ehMnnst/s4aLU3XgzEcLANjyBvuM0tSscZlLB7UslsnbRha5HvSKNGQdfbU3u+g3GlDM/zI9R 5urjKc7bh/8Us5ogJwMg4+NsvlVRBSceyTH8iT1BN+HOY3lTpt7nQfdzXJHHHlrxC60xI5c72 nK8o8q3RbaJfGn9dSVfv2tAa2YovTWSfJGYEMF1tFM7r0jbhozR7y7q+wocgqVnxa7F7vb8jH /wEmd2Eckj9xouryrgFqlF8cuRkQvsN78NlZAw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday 08 September 2015 18:48:07, Eric Anholt wrote: > I finally had a chance to sit down and look at what the hardware's doing > with the enable bit (also, I've read a whole lot more of the hardware > now, so I'm a lot faster at answering questions like this). The enable > bits are a clock gate off of the VPU clock. Are any hardware documents about such things available (in public)? > I knocked together the enable bits as a clock gate driver, since I'd > just written very similar code for the audio domain clock driver (and I > assume you are grumpy about how much time you've spent on this one > stupid register). It's up at > https://github.com/anholt/linux/tree/bcm2835-clock-aux and I can submit > it if you like the result. I've compile tested it only, but I'm hoping > you could just drop your aux SPI driver on top of it and have things > work. IMHO line 45 (https://github.com/anholt/linux/commit/facb4ba917a1b9f6c2ee0cea7d529acf55f584dd#diff-1b6f753c132811b3f6d70f5b31866950R45) should be like this > onecell->clks = kzalloc(sizeof(*onecell->clks) * BCM2835_AUX_CLOCK_COUNT, GFP_KERNEL); or you will only allocate a single struct clk*. Best regards, Alexander