From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADBA8EDEC6A for ; Wed, 13 Sep 2023 14:49:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241492AbjIMOt5 (ORCPT ); Wed, 13 Sep 2023 10:49:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237004AbjIMOtz (ORCPT ); Wed, 13 Sep 2023 10:49:55 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:242:246e::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FB16AB; Wed, 13 Sep 2023 07:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=AKHZcby/SaXTGDFhOnska1CWWaoisj9GGC+K/yEWJ4Q=; t=1694616591; x=1695826191; b=kwDyAT00bHSpRwewzqF3UYKycN+H9le5OeUr0GJjzwXGNAU h6KBg/sh3ykqTeoF4NjxkEyCWwSpJM0OnavJ6wEaaBzcHJmCt8uaV9kVu/lqxIKJzLV3TPQuS0+Ha Llbc+X9sez0cSwhJb8Hm123z101sGgBtaDVXXxdUk5UZgM6lVQ6YDqOlFB/rCFmB6SMu1AhTn1sNU sHpW/KkYrBG3odYYgFXs3mD/fh7mOyMtRrj9CnvrtWDG8wpMOTe+j8LPBeK/NWR8yk6QoqJdXZjSg JgAjzXEUSYLZd+Ax56U7DW+F+SFC31a+pCQe8vZTU0Rbb0shfX59Vrbw1/FUnaPA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1qgRBU-00F30o-2d; Wed, 13 Sep 2023 16:49:41 +0200 Message-ID: <27579950c5a5f9221e7b52524cbc8de97d8b90e0.camel@sipsolutions.net> Subject: Re: [REGRESSION] [PATCH net-next v5 2/2] net: stmmac: use per-queue 64 bit statistics where necessary From: Johannes Berg To: Jisheng Zhang Cc: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Lucas Stach , Maxime Coquelin , Eric Dumazet , Samuel Holland , netdev@vger.kernel.org, "David S . Miller" , Alexandre Torgue , Jernej Skrabec , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Jose Abreu , kernel@pengutronix.de, Giuseppe Cavallaro , Jakub Kicinski , Paolo Abeni , linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Date: Wed, 13 Sep 2023 16:49:39 +0200 In-Reply-To: References: <20230717160630.1892-1-jszhang@kernel.org> <20230717160630.1892-3-jszhang@kernel.org> <20230911171102.cwieugrpthm7ywbm@pengutronix.de> <99695befef06b025de2c457ea5f861aa81a0883c.camel@pengutronix.de> <20230912092411.pprnpvrbxwz77x6a@pengutronix.de> <2fcc9fb0e40ceff8ea4ae55cca3ce0aff75a20ca.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2023-09-13 at 22:34 +0800, Jisheng Zhang wrote: >=20 > Since we are in rc1, I need to fix the bug with as small changes as > possible. so another solution could be: replace rx/tx stats structure > with pointers, then setup pointers in the new allocated dma_conf with > the old one as current code did for dma_tx_size/dma_rx_size in > stmmac_setup_dma_desc(): >=20 > dma_conf->dma_tx_size =3D priv->dma_conf.dma_tx_size >=20 > Is it acceptable? I'm not sure who you're asking of all the people in this thread, but I honestly don't understand much about this driver other than what I gleaned in the few minutes looking at it with Uwe ... so I don't think I'm able to answer that question :) You could also just move the stats out of the structure entirely, I guess? And perhaps even start some new structure where more things might move in the future that shouldn't be reallocated? I'm all for not moving things now that haven't caused problems, but I guess doing a minimal fix just for the sake of being minimal in -rc1 wouldn't be my preference. johannes