From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 008023DA7EC for ; Tue, 26 May 2026 11:21:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779794506; cv=none; b=pJ8866Y8tplUPeJ4KxkOA5dJG06VzmAGY1rVxu99a76xkYGeO+h5Z7uqt8KVZk2jl1Fy7s5BwThfhfKc6bwXP13VPIxBjeyjGTLmo4G3410oKOy2E8+20ouk5OFSm7EGKRIUWwRhAIbzgqL98o/nIP7ent0T+eUYzgMb0r3Cxuc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779794506; c=relaxed/simple; bh=i/pTzMVi9XbOmZoluvn42b58PFWtzW94v/MUSd3ggjY=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=eq6sSQ0un/GSOfDtb9Vs+LT4hlJIp5l/KOlDmq6Uqz8uiESorDpgtkoqrUTfZvJ4p7PsyZHigSScKmzP9b8yqbehdQGRViwdx8hxIoYftijL7CEciGPRTe1xLUB8PNFNzEweTClGdKAU6YI/evqxpDP22jy9GT+6nxQAW/QEVpw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=McMcpSj3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Shh9r3tp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="McMcpSj3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Shh9r3tp" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64Q5sAcl1802358 for ; Tue, 26 May 2026 11:21:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 657l6qX2PWzLBimaQHEMg2HJ1WHmLAQaXwJId8moVA8=; b=McMcpSj354sThUE1 mYD59EORxNrXnhcSVzzJVxU/mtgBOTkATHS3zgzpFAJgFzOCrZ6Tko9QcRFX4fdG pjO/cSrfmFsIXqG1Fw7Ao+Ras3SPAAQV63vtpdpB+azxJWxOrGkxzP+cwyxpmql1 mRRhTVOo6NwaBvRWNf0+jzf3jb3IsstT0cj7NGw+SyGajOJL2J5Fd/8gFPX2OMiO +gtHnIgX1IVHJnvyEIDB0PSekbn3xyg1BAdfZoOFcdvA4Z5K/j+K1CcxJtgrUD2/ z3z4W3alIsFRXRbx2o8KKfCwZu8NS6qvdcKgUni8T3BjfMJcYOw3WsWE1Vy2pWuw H6qBFQ== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eckyqmff6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 26 May 2026 11:21:43 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-8397b14a689so6443039b3a.2 for ; Tue, 26 May 2026 04:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779794503; x=1780399303; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=657l6qX2PWzLBimaQHEMg2HJ1WHmLAQaXwJId8moVA8=; b=Shh9r3tpPtbl2WDGhZhQrhFYS/4uUtYjEoZdpKg9BWu3oGjphyP+Xft/9Y339MMGjG XsDnu5X9yghE5ZB3v4qTUp/hX/smR6iG5PEJVE8XsdBXvYGfdlat/JnoxFnzKIWOWByp WAGwxAwonBDkiSj3PTwohPaA+uu4HqADBlM3D4Wd0gKCmCFR8CaRpXtzYpsMCSsFCa44 dvTDlwrDd81oURTjnmQNy6GjeXVh9yUGyPkb0Ohr3g4E5yrMmLfmZ5GJkl22p5uq6xNe yY7enGpejh0hb7dcMfQ0vzMSKhBYXsL3Nvxt0pEpT19qkABNGFAZ9BT+61/kFg8gbsHS c3Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779794503; x=1780399303; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=657l6qX2PWzLBimaQHEMg2HJ1WHmLAQaXwJId8moVA8=; b=kx8rFJhBYn/24MmvRQRrzP/2n60orPWe4JPWEV87mCJtJoZ3+yAbwrEzNSOi6wDijj 3FuN85j2sK2B1eUWqYe+ygsWsHT0equGvccwsCXPCV2JRu0373WSWTwKHSYKBBFnQtGP NXJ+kXGWXiLD+EsI7/Or32RcX7p1/OPRgKmMcnTgvw8SK1KBOt58MvcIoBoUFbdRB1He KIQyJAdLNl69txpGoQBfBQ6Wi+ZZ2BQGK1dVgtmmZShcL0DeYFIu3MjeL6n4ud9NXkf+ +ErHdFjL1h33MeDEyKSDzGOoEJIX1uq357/4t/MHymy7cC1MZuFgibjHblnOK1scjA7p BdlQ== X-Forwarded-Encrypted: i=1; AFNElJ9p0IQqZKXXH2F+KBcLrH0sUSnrgmYuHyeCQgBGDLbsz8qKxUgPIaeGHaTShMAgQLLnWPFhUAbV7ILO0Y4=@vger.kernel.org X-Gm-Message-State: AOJu0YxlSW6SafWVA3cWQu78i4/stmIu47BjTjEl6+6qU8Imcq3bHe32 z4axdpEDpIvkB1aHwM7Ob7u4e1ZQ/Zpo5feB1CjmbJF8B1VWkiPXk3+XvKkZSSLubhYEnJaPD1t Rbc7LrCN6o8FUO+BHvj/2DhVepEuqY6xm19M1TCTDmQQ1B59eSPDtAdJhu6mCeXlhm8Q= X-Gm-Gg: Acq92OETBRHvsblPNZyRZRJ1tSgZHAANNzpwLLzNSBUXvhBVvePxqVKvtNacwbnZYnS cqF9I8+K56ukScDkmNStkdicDdreQWTNLVIET5Uxik7JdxY6dJDVxB/FXGJOhtWDvmjH7PPRmqh cxZ9OoGlnaQ9n2vXmQ6MRnG4KbvdH5fBc//iImU1dQgpIBsJxa3cTtEkGztVcvnD2fKenEUP4XJ EN+l+upEmZ/aJ97qoodCIGKtnD0la787fX3JzY0kdOQuQIGX/o08YT5OGaIZO1d3lhWMNycgidq JuflMF0Nj/M1TFrYURXjEA7QNncwAGbzxxP9xfytAvx0FlQzfNOvVUW3ezhwF2crC2eNMLPnyOB 53hyiKLcA0SvnNvupkLoKttR1wC4yaMIQXM/eTcrwOXxNItkcekiZaQ== X-Received: by 2002:a05:6a00:1988:b0:838:127d:a16e with SMTP id d2e1a72fcca58-8415f33166bmr15334900b3a.17.1779794502950; Tue, 26 May 2026 04:21:42 -0700 (PDT) X-Received: by 2002:a05:6a00:1988:b0:838:127d:a16e with SMTP id d2e1a72fcca58-8415f33166bmr15334846b3a.17.1779794502360; Tue, 26 May 2026 04:21:42 -0700 (PDT) Received: from [10.206.105.200] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164ac9b74sm11949564b3a.3.2026.05.26.04.21.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 04:21:41 -0700 (PDT) Message-ID: <2757cc51-f755-905e-3dae-4f4cf12db15b@oss.qualcomm.com> Date: Tue, 26 May 2026 16:51:32 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Vishnu Reddy Subject: Re: [PATCH v5 03/14] media: iris: Fix VM count passed to firmware To: Dmitry Baryshkov Cc: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Joerg Roedel , Will Deacon , Robin Murphy , Hans Verkuil , Stefan Schmidt , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stanimir Varbanov , Jorge Ramirez-Ortiz , Del Regno , Bjorn Andersson , Konrad Dybcio , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, Krzysztof Kozlowski , devicetree@vger.kernel.org, stable@vger.kernel.org References: <20260509-glymur-v5-0-7fbb340c5dbd@oss.qualcomm.com> <20260509-glymur-v5-3-7fbb340c5dbd@oss.qualcomm.com> <11c63862-5e8b-9f3a-5479-706e672879a5@oss.qualcomm.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=RMyD2Yi+ c=1 sm=1 tr=0 ts=6a158247 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=FhdRzFEOr7cjOW0uG60A:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: wZKLPt0szY8cOTF-NB3oLGgQXv7mIdKu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI2MDA5OSBTYWx0ZWRfXxlFpm8XZV9hT WRvt++xV23dx1XfB65wCcwcoOR3ZXynz06xjE/WZhOKjlOVEYNOw4VyHb07wZOWLEwa8zKGKRoF LX7TzeDipvfCO62sxQO6CQtS8j8V3S8qS9rJGfPnzL2eOXNnsfm71LPH6nJzqLEHu4gXRz0WJw2 8rra2KZC7OF40M9N1Fto18h3+MzSebUSp9ZAWMXGYiT6PIQqpKQh2/2OGM3SlWgOU3KcbILHuBs S4QC76rEGU5c9zE/CCCKmBIrN0Ij1elfmMpzl3MaxoX0hfvcNPOorLZc+zoU0kOyU45Tz3rYkb4 C6NHTbW9hz5grKK/QPb87fdivRD4f8nvvjW83CxofszYy3v/jn3To5mSzgha4Q0xtf+EdZd4Ds0 KG0En0P1h1VlfX4QP4JaZoUPXzNgWpSchm2osgxH2lFpjzI+cfPOaMsO8GezoOKwiIJPhkAdDei sTqWuw9A30jI2+xVPzA== X-Proofpoint-GUID: wZKLPt0szY8cOTF-NB3oLGgQXv7mIdKu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-26_02,2026-05-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 adultscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605260099 On 5/17/2026 10:59 PM, Dmitry Baryshkov wrote: > On Fri, May 15, 2026 at 04:48:44PM +0530, Vishnu Reddy wrote: >> On 5/9/2026 12:50 AM, Dmitry Baryshkov wrote: >>> On Sat, May 09, 2026 at 12:29:52AM +0530, Vishnu Reddy wrote: >>>> On Glymur, firmware interprets the value written to CPU_CS_SCIACMDARG3 as >>>> the number of virtual machines (VMs) and internally adds 1 to it. Writing >>>> 1 causes firmware to treat it as 2 VMs. Since only one VM is required, >>>> remove this write to leave the register at its reset value of 0. This does >>>> not affect other platforms as only Glymur firmware uses this register, >>>> earlier platform firmwares ignore it. >>> The explanation is pretty suspicious. I can see this write in venus >>> sources too and it was added in the initial submission, dating 2017. The >>> driver targeted two platforms, MSM8916 and MSM8996, so this write >>> predates Glymur pretty much. >> Thank you for the historical context! I checked with the firmware team and >> confirmed that this register is not read by any of the platform firmwares >> currently supported in the Iris driver. Regarding MSM8916 and MSM8996, those >> are not supported in the Iris driver. > So, which platforms actually needed that register? The "currently > supported" is not strong enough. We are bringing in Agatti support and > support for SM8150 and SDM845 is in discussion. I would not be surprised > if we end up porting other older platforms too. So, you are changing the > historical behaviour. You need to document the applicability of the > change. Apologies for the late reply, I was on vacation last week. I'll move this to a glymur-specific vpu_ops hook and keep the existing behavior for the remaining platforms. >>>> Fixes: abf5bac63f68 ("media: iris: implement the boot sequence of the firmware") >>>> Cc: stable@vger.kernel.org >>>> Reviewed-by: Vikash Garodia >>>> Signed-off-by: Vishnu Reddy >>>> --- >>>> drivers/media/platform/qcom/iris/iris_vpu_common.c | 1 - >>>> 1 file changed, 1 deletion(-) >>>>