From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932096AbaESXFd (ORCPT ); Mon, 19 May 2014 19:05:33 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:63117 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752137AbaESXFS (ORCPT ); Mon, 19 May 2014 19:05:18 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: Stratos Karafotis , "linux-pm@vger.kernel.org" , LKML Subject: Re: [PATCH v2] cpufreq: powernow-k8: Suppress checkpatch warnings Date: Tue, 20 May 2014 01:22:12 +0200 Message-ID: <2759682.X7CU1JTh4P@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.15.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <536FB2B8.1060505@semaphore.gr> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, May 12, 2014 09:52:06 AM Viresh Kumar wrote: > On 11 May 2014 22:56, Stratos Karafotis wrote: > > Suppress the following checkpatch.pl warnings: > > > > - WARNING: Prefer pr_err(... to printk(KERN_ERR ... > > - WARNING: Prefer pr_info(... to printk(KERN_INFO ... > > - WARNING: Prefer pr_warn(... to printk(KERN_WARNING ... > > - WARNING: quoted string split across lines > > - WARNING: please, no spaces at the start of a line > > > > Also, define the pr_fmt macro instead of PFX for the module name. > > > > Signed-off-by: Stratos Karafotis Queued up for 3.16, thanks! > > --- > > > > Changes v1 -> v2 > > - Use pr_err_once instead of printk_once > > - Change missing_pss_msg to macro (because pr_err_once > > doesn't compile otherwise) > > - Put one pr_err message in a single line instead of two > > - Ignore "line over 80 characters" warnings > > - Change the word "Fix" in the subject of the patch to > > "Suppress" as the patch doesn't really fix anything > > > > drivers/cpufreq/powernow-k8.c | 180 +++++++++++++++++------------------------- > > drivers/cpufreq/powernow-k8.h | 2 +- > > 2 files changed, 74 insertions(+), 108 deletions(-) > > Acked-by: Viresh Kumar > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.