From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934435AbeEILfG (ORCPT <rfc822;w@1wt.eu>);
        Wed, 9 May 2018 07:35:06 -0400
Received: from fllnx209.ext.ti.com ([198.47.19.16]:12050 "EHLO
        fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933883AbeEILfE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 9 May 2018 07:35:04 -0400
Subject: Re: [PATCH] leds: lm3601x: fix semicolon.cocci warnings
To: Julia Lawall <julia.lawall@lip6.fr>
CC: <robh+dt@kernel.org>, <mark.rutland@arm.com>,
        <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-leds@vger.kernel.org>, <kbuild-all@01.org>
References: <alpine.DEB.2.20.1805091023520.3379@hadrien>
From: Dan Murphy <dmurphy@ti.com>
Message-ID: <27624117-6a8b-e94c-7dce-c5cb09d733f6@ti.com>
Date: Wed, 9 May 2018 06:34:43 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1805091023520.3379@hadrien>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

All

On 05/09/2018 03:26 AM, Julia Lawall wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Fixes: b550389fcb74 ("leds: lm3601x: Introduce the lm3601x LED driver")
> CC: Dan Murphy <dmurphy@ti.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> 
> url:
> https://github.com/0day-ci/linux/commits/Dan-Murphy/dt-bindings-lm3601x-Introduce-the-lm3601x-driver/20180509-033939
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
> for-next
> :::::: branch date: 5 hours ago
> :::::: commit date: 5 hours ago
> 
> I also received the following comment, but no other details.  It would be
> good to check what is going on on the mentioned lines.
> 
>>> drivers/leds/leds-lm3601x.c:315:2-8: preceding lock on line 311
> 
>  leds-lm3601x.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/leds/leds-lm3601x.c
> +++ b/drivers/leds/leds-lm3601x.c
> @@ -234,7 +234,7 @@ static int lm3601x_strobe_set(struct led
> 
>  		ret = -EINVAL;
>  		goto out;
> -	};
> +	}
> 

I will fix this in v3 of the patch submission.

Dan

>  	if (led->strobe_timeout != current_timeout)
>  		ret = regmap_update_bits(led->regmap, LM3601X_CFG_REG,
> 


-- 
------------------
Dan Murphy