From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751294AbdEBL35 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 2 May 2017 07:29:57 -0400
Received: from mailout2.samsung.com ([203.254.224.25]:12857 "EHLO
        mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750892AbdEBL3z (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 2 May 2017 07:29:55 -0400
X-AuditID: b6c32a2e-f79506d0000046c0-b9-59086db0d7e2
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, linux-fbdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH] m501fb: don't return zero on failure path in
 sm501fb_start()
Date: Tue, 02 May 2017 13:29:49 +0200
Message-id: <2764518.z4Gir5H5x7@amdc3058>
User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <1493494419-3917-1-git-send-email-khoroshilov@ispras.ru>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset="us-ascii"
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42LZdlhTU3dDLkekwb7PMhY71u1kt1je3cVi
        caLvA6vF5V1z2CzWz7/F5sDqMePfVEaPO6//snocv7GdyePzJrkAligum5TUnMyy1CJ9uwSu
        jOl/5jIW9LNULL+zj7mBcRtzFyMnh4SAicSNR9egbDGJC/fWs3UxcnEICSxllLh08jk7hPOZ
        UWLlvRdADgdYx/R3phDxHYwS8+Z8YATpFhL4yijx5UA+iM0mYCUxsX0VWFxEQE/i46utTCAN
        zAKtjBL/2o+ygySEBYIlrr99CbaaRUBVYt6qvWwgNq+ApsTpCV+ZQGxRAS+JLfvawWxOAVeJ
        vnPbGCFqBCV+TL7HAmIzC8hL7Ns/lRXC1pE4e2wdI8gyCYFmdomby/+xQlwtK7HpANSbLhJ3
        Vx5ih7CFJV4d3wJlS0l0d8yCsqczSmz/LQExZzOjxKrdE6AS1hKHj1+EWsYn0fv7CRPEfF6J
        jjYhiBIPiWv79kGVO0pseLeBERJaMxglFl59yziBUX4Wkh9mIflhFpIfFjAyr2IUSy0ozk1P
        LTYtMNYrTswtLs1L10vOz93ECE4bWno7GP8t8D7EKMDBqMTDu6CcPVKINbGsuDL3EKMEB7OS
        CK+MD0ekEG9KYmVValF+fFFpTmrxIUZpDhYlcV6NldcihATSE0tSs1NTC1KLYLJMHJxSDYz8
        Iiaf/W7lFk268na6HKMWm1BdiEKIR8EutdS/fXs1fxt+bNH8/ODA2vVnjSt8tK4kSQRc2X5/
        0VETiYI5u3R+C2+V0fPsvihxMzn9Q3xM4+SjrV+N+uOe7Nybl/h6Ad/72c/Oq7t/miK959xz
        izuXpSKPJi2bPsFzVzvb5s4gLYlWp1+f2V2UWIozEg21mIuKEwEQnoToFwMAAA==
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsVy+t9jAd0NuRyRBle28lrsWLeT3WJ5dxeL
        xYm+D6wWl3fNYbNYP/8WmwOrx4x/Uxk97rz+y+px/MZ2Jo/Pm+QCWKLcbDJSE1NSixRS85Lz
        UzLz0m2VQkPcdC2UFPISc1NtlSJ0fUOClBTKEnNKgTwjAzTg4BzgHqykb5fgljH9z1zGgn6W
        iuV39jE3MG5j7mLk4JAQMJGY/s60i5ETyBSTuHBvPVsXIxeHkMA2RolVz/qZIZyvjBLzei+y
        gFSxCVhJTGxfxQhiiwjoSXx8tZUJpIhZoJVR4kTnJbCEsECwxPW3L5lBbBYBVYl5q/aygdi8
        ApoSpyd8ZQKxRQW8JLbsawezOQVcJfrObWOE2DaLUeJa32d2iAZBiR+T74FtZhaQl9i3fyor
        hK0lsX7ncaYJjEDVCGWzkJTNQlK2gJF5FSNXakFxbnpusVGB0SZGYLRsO6wVsIOx6Vz0IUYB
        DkYlHl6GJI5IIdbEsuLK3EOMEhzMSiK8Mj5AId6UxMqq1KL8+KLSnNTiQ4ymQD9NZJYSTc4H
        RnJeSbyhiaWRiYGZmaGRgbGZkjjvhMAvEUIC6YklqdmpqQWpRTB9TBycUg2MguIi+rE7zly9
        EVC9ye/53p3OQXqvz5feTfOclC1zVXsR5/I/MTG63vpHRVfNalgd1OyQE9uYvGKq5LbaQ5pZ
        8+Wvvmb761mZYRC3Yv2Flakpq6fpnK39GDlDq7JS4+718td6jVMF+N03s69zFyx2mfh/zfp1
        caGcu777b1oT88wiLZF193RGJZbijERDLeai4kQAkif3q6wCAAA=
X-MTR: 20000000000000000@CPGS
X-CMS-MailID: 20170502112952epcas5p23f91f1c12927a0ddef015e138c9fe9c9
X-Msg-Generator: CA
X-Sender-IP: 182.195.42.80
X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?=
        =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?=
X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?=
        =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?=
        =?UTF-8?B?bmdpbmVlcg==?=
X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?=
CMS-TYPE: 105P
X-CMS-RootMailID: 20170429193354epcas1p49764e384389a15121894ef6a032b791f
X-RootMTR: 20170429193354epcas1p49764e384389a15121894ef6a032b791f
References: <CGME20170429193354epcas1p49764e384389a15121894ef6a032b791f@epcas1p4.samsung.com>
        <1493494419-3917-1-git-send-email-khoroshilov@ispras.ru>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Saturday, April 29, 2017 09:33:39 PM Alexey Khoroshilov wrote:
> If fbmem iomemory mapping failed, sm501fb_start() breaks off
> initialization, deallocates resources, but returns zero.
> As a result, double deallocation can happen in sm501fb_stop().
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Patch queued for 4.12, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics