From: "Zhengbin (OSKernel)" <zhengbin13@huawei.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<gaochao49@huawei.com>
Subject: Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind
Date: Thu, 16 Jun 2022 14:10:17 +0800 [thread overview]
Message-ID: <27654cfe-4d6e-8b5f-aaee-9f9a3117b3a2@huawei.com> (raw)
In-Reply-To: <20220609222239.5fssqczkdqy4inoz@mercury.elektranox.org>
On 2022/6/10 6:22, Sebastian Reichel wrote:
> Hi,
>
> On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
>> ab8500_charger_bind misses destroy_workqueue in error path,
>> this patch fixes that.
>>
>> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
>> ---
> LGTM, but adding Linus to Cc and waiting a bit to give him time to
> react.
>
> -- Sebastian
ping
>
>> drivers/power/supply/ab8500_charger.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
>> index d04d087caa50..a5d055a628e7 100644
>> --- a/drivers/power/supply/ab8500_charger.c
>> +++ b/drivers/power/supply/ab8500_charger.c
>> @@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
>> ret = component_bind_all(dev, di);
>> if (ret) {
>> dev_err(dev, "can't bind component devices\n");
>> + destroy_workqueue(di->charger_wq);
>> return ret;
>> }
>>
>> --
>> 2.31.1
>>
next prev parent reply other threads:[~2022-06-16 6:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 9:38 Zheng Bin
2022-06-07 13:16 ` Zhengbin (OSKernel)
2022-06-09 22:22 ` Sebastian Reichel
2022-06-16 6:10 ` Zhengbin (OSKernel) [this message]
2022-06-23 14:20 ` Linus Walleij
2022-07-16 23:08 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27654cfe-4d6e-8b5f-aaee-9f9a3117b3a2@huawei.com \
--to=zhengbin13@huawei.com \
--cc=gaochao49@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®