From: Joe Perches <joe@perches.com>
To: Tom Rix <trix@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
alain@knaff.lu
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] decompress_bunzip2: fix sizeof type in start_bunzip
Date: Sun, 12 Jul 2020 14:49:44 -0700 [thread overview]
Message-ID: <27660a3e38af43c9e741a4dfcdec50757c32f409.camel@perches.com> (raw)
In-Reply-To: <9af191c2-0f2c-7637-433a-b557a07590ca@redhat.com>
On Sun, 2020-07-12 at 08:12 -0700, Tom Rix wrote:
> On 7/12/20 6:09 AM, H. Peter Anvin wrote:
> > On 2020-07-12 05:59, trix@redhat.com wrote:
> > > From: Tom Rix <trix@redhat.com>
[]
> > > So change the type in sizeof to 'unsigned int'
> > You must be kidding.
> >
> > If you want to change it, change it to sizeof(bd->dbuf) instead, but this flag
> > is at least in my opinion a total joke. For sizeof(int) != sizeof(unsigned
> > int) is beyond bizarre, no matter how stupid the platform.
>
> Using the actual type is more correct that using a type of the same size.
Sure.
But this hardly matters as this same type conversion
from signed to unsigned or the other way round is
_everywhere_ in the kernel.
And especially the cc of stable is unnecessary.
next prev parent reply other threads:[~2020-07-12 21:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-12 12:59 trix
2020-07-12 13:09 ` H. Peter Anvin
2020-07-12 15:12 ` Tom Rix
2020-07-12 21:49 ` Joe Perches [this message]
2020-07-12 22:21 ` hpa
2020-07-13 19:27 ` Tom Rix
2020-07-13 19:51 ` hpa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27660a3e38af43c9e741a4dfcdec50757c32f409.camel@perches.com \
--to=joe@perches.com \
--cc=alain@knaff.lu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®