From: Shuah Khan <skhan@linuxfoundation.org>
To: Vinicius Peixoto <vpeixoto@lkcamp.dev>,
Diego Vieira <diego.daniel.professional@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com
Cc: n@nfraprado.net, andrealmeid@riseup.net, vinicius@nukelet.com,
~lkcamp/patches@lists.sr.ht,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 0/1] Add KUnit tests for kfifo
Date: Thu, 3 Oct 2024 15:41:18 -0600 [thread overview]
Message-ID: <2767f7da-355c-4abf-9eb7-b409e0c9ccab@linuxfoundation.org> (raw)
In-Reply-To: <04b041a2-d38c-4399-b4a5-1506b5a23e55@lkcamp.dev>
On 9/21/24 17:15, Vinicius Peixoto wrote:
> Hi all,
>
> On 9/3/24 18:36, Diego Vieira wrote:
>> Hi all,
>>
>> This is part of a hackathon organized by LKCAMP [1], focused on writing
>> tests using KUnit. We reached out a while ago asking for advice on what would
>> be a useful contribution [2] and ended up choosing data structures that did
>> not yet have tests.
>>
>> This patch series depends on the patch that moves the KUnit tests on lib/
>> into lib/tests/ [3].
>>
>> This patch adds tests for the kfifo data structure, defined in
>> include/linux/kfifo.h, and is inspired by the KUnit tests for the doubly
>> linked list in lib/tests/list-test.c (previously at lib/list-test.c) [4].
>>
>> [1] https://lkcamp.dev/about/
>> [2] https://lore.kernel.org/all/Zktnt7rjKryTh9-N@arch/
>> [3] https://lore.kernel.org/all/20240720181025.work.002-kees@kernel.org/
>> [4] https://elixir.bootlin.com/linux/latest/source/lib/list-test.c
>>
>> ---
>> Changes in v2:
>> - Add MODULE_DESCRIPTION()
>> - Move the tests from lib/kfifo-test.c to lib/tests/kfifo_kunit.c
>>
>> Diego Vieira (1):
>> lib/tests/kfifo_kunit.c: add tests for the kfifo structure
>>
>> lib/Kconfig.debug | 14 +++
>> lib/tests/Makefile | 1 +
>> lib/tests/kfifo_kunit.c | 224 ++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 239 insertions(+)
>> create mode 100644 lib/tests/kfifo_kunit.c
>>
>
> Gentle ping, is there any chance could we get some opinions on this? :-)
>
> I know that this patch is quite big, plus LPC just ended and people are probably very busy, but we would really appreciate some feedback on this one. Thanks in advance!
>
Which repo is this based on?
thanks,
-- Shuah
prev parent reply other threads:[~2024-10-03 21:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 21:36 Diego Vieira
2024-09-03 21:36 ` [PATCH v2 1/1] lib/tests/kfifo_kunit.c: add tests for the kfifo structure Diego Vieira
2024-10-01 20:45 ` Rae Moar
2024-10-11 7:22 ` David Gow
2024-09-21 23:15 ` [PATCH v2 0/1] Add KUnit tests for kfifo Vinicius Peixoto
2024-10-03 21:41 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2767f7da-355c-4abf-9eb7-b409e0c9ccab@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=andrealmeid@riseup.net \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=diego.daniel.professional@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=n@nfraprado.net \
--cc=rmoar@google.com \
--cc=vinicius@nukelet.com \
--cc=vpeixoto@lkcamp.dev \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®