From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from imap5.colo.codethink.co.uk (imap5.colo.codethink.co.uk [78.40.148.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96A39366DA5 for ; Mon, 29 Jun 2026 11:09:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.40.148.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782731342; cv=none; b=Tg2k0kNQEreDVVsRNr2PNISkx893NxKCem0AQKDNpC+xyKFbq0r1q64vTAw/tA37SNHh93D52KMiXdDKjPP4lGdLgNIAbKXsA+geWVJmY/OR64eAJPZUWkz+2bRIOEQiAnHoad15g4WpG8AO8j+aJe8LsNw9XiHB5BlOGLMEE0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782731342; c=relaxed/simple; bh=G5sgCYdfqEgTDJmqXSNTG/hLv68f03c7utH13dRbI9s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WMlIiV1KpMjL3HLzaXDZN7WzVBLyjraHjU1ygGbPYh3KJjAUtLtT45d9KIpLsldW1fq64DyaWl4vurIv5znS5SzZwsaoZYM3YXIGs+aR85fSoz7FI5NbUOI/C6yrc5Y7SgXkxJEiQlRJTdr+VinFSC5Pez+7EkQrKPvLjAnJ7Ss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk; spf=pass smtp.mailfrom=codethink.co.uk; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b=R3zuo4BC; arc=none smtp.client-ip=78.40.148.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b="R3zuo4BC" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codethink.co.uk; s=imap5-20230908; h=Sender:Content-Transfer-Encoding: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Reply-To; bh=iMvLa3m/MTxjymke0lyeRSF+rdUhBWHoQ0wYwpxzL64=; b=R3zuo4BCpfrRInEp sINOybonM4Z5ElnYeWwJZNbNzm0Tzn0FaA6bcK/kGgMg10fcmbaP3MkTjhrDyqKTbImfJaGu4zDM2 cYCHFGI0AILG5qePws4EJBYEg2kRm+Dtz+X+7TPOQHCbetNOMX41YXDd9BM9KdXfk1BS88DnSujGh h97LFdoOk6LU6jMWglYdrZugoP6m4fNzygFoBPtMvZQVLDawYFuvMoYxV03OgvTdYa5iPfUDxdRqG FCDBSk7HWKPIRIFEIkG2idq4fUW7L5TfjRI5CfIe/tkfUzvoeNtwMFy4AaZP2HLvZQbmZToPiu6dd woe2RijRqQ21Lsv/iw==; Received: from [167.98.27.226] (helo=[10.35.6.194]) by imap5.colo.codethink.co.uk with esmtpsa (Exim 4.94.2 #2 (Debian)) id 1we9r6-000OrL-I8; Mon, 29 Jun 2026 12:08:48 +0100 Message-ID: <276820f5-76fe-4e6b-b1b3-d9235d097411@codethink.co.uk> Date: Mon, 29 Jun 2026 12:08:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/page_alloc: don't build vm_numa_stat_key if CONFIG_NUMA=n To: Andrew Morton Cc: Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260618100614.1321950-1-ben.dooks@codethink.co.uk> <20260624192742.afbd255b97d82ecfe7e11e17@linux-foundation.org> Content-Language: en-GB From: Ben Dooks Organization: Codethink Limited. In-Reply-To: <20260624192742.afbd255b97d82ecfe7e11e17@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: ben.dooks@codethink.co.uk On 25/06/2026 03:27, Andrew Morton wrote: > On Thu, 18 Jun 2026 11:06:14 +0100 Ben Dooks wrote: > >> The vm_numa_stat_key is only exported if CONFIG_NUMA is set, >> so avoid the following warning by guarding it in an #ifdef >> on CONFIG_NUMA: >> >> mm/page_alloc.c:165:1: warning: symbol 'vm_numa_stat_key' was not declared. Should it be static? >> >> ... >> >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -162,7 +162,9 @@ DEFINE_PER_CPU(int, numa_node); >> EXPORT_PER_CPU_SYMBOL(numa_node); >> #endif >> >> +#ifdef CONFIG_NUMA >> DEFINE_STATIC_KEY_TRUE(vm_numa_stat_key); >> +#endif >> >> #ifdef CONFIG_HAVE_MEMORYLESS_NODES >> /* > > It might be tidier to move this into mm/vmstat.c, around line 38? Is it worth sending a version of the patch? -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html