From: "Csókás Bence" <csokas.bence@prolan.hu>
To: <linux-spi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Varshini Rajendran <varshini.rajendran@microchip.com>,
Mark Brown <broonie@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>
Subject: Re: [PATCH v3 2/2] spi: atmel-quadspi: Add support for sama7g5 QSPI
Date: Tue, 14 Jan 2025 18:21:52 +0100 [thread overview]
Message-ID: <2768b17c-bba8-452c-8148-cfbf1ed5393f@prolan.hu> (raw)
In-Reply-To: <20250110-paycheck-irregular-bcddab1276c7@thorsis.com>
Hi,
On 2025. 01. 10. 8:56, Alexander Dahl wrote:
> Hello,
>
> found another suspicious area regarding pm_runtime in
> atmel_qspi_probe(), see below (irrelevant stuff dropped this time) …
>
> Am Thu, Nov 28, 2024 at 06:43:15PM +0100 schrieb Csókás, Bence:
>> From: Tudor Ambarus <tudor.ambarus@microchip.com>
>>
>
> […]
>
>> pm_runtime_set_autosuspend_delay(&pdev->dev, 500);
>> pm_runtime_use_autosuspend(&pdev->dev);
>> @@ -745,7 +1444,9 @@ static int atmel_qspi_probe(struct platform_device *pdev)
>> pm_runtime_enable(&pdev->dev);
>> pm_runtime_get_noresume(&pdev->dev);
>>
>> - atmel_qspi_init(aq);
>> + err = atmel_qspi_init(aq);
>> + if (err)
>> + goto dma_release;
>
> This error handling leads to unbalanced pm_runtime right? The block
> below rolls back pm_runtime before jumping to 'dma_release', this here
> does not.
>
>> err = spi_register_controller(ctrl);
>> if (err) {
>> @@ -753,13 +1454,16 @@ static int atmel_qspi_probe(struct platform_device *pdev)
>> pm_runtime_disable(&pdev->dev);
>> pm_runtime_set_suspended(&pdev->dev);
>> pm_runtime_dont_use_autosuspend(&pdev->dev);
>> - goto disable_qspick;
>> + goto dma_release;
>> }
>
> This hunk got it right?
Hm, I think this would be best handled by switching to
`devm_pm_runtime_enable()`... I'll add that to my upcoming "make
everything use devm_*()"-series... (but I'm waiting on new functions to
be added to dmaengine for that).
Bence
next prev parent reply other threads:[~2025-01-14 17:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 17:43 [PATCH v3 0/2] spi: atmel-quadspi: Refactor to allow supporting SAMA7G5 O/QSPI Csókás, Bence
2024-11-28 17:43 ` [PATCH v3 1/2] spi: atmel-quadspi: Create `atmel_qspi_ops` to support newer SoC families Csókás, Bence
2024-11-28 17:43 ` [PATCH v3 2/2] spi: atmel-quadspi: Add support for sama7g5 QSPI Csókás, Bence
2024-12-18 9:32 ` Alexander Dahl
2025-01-09 16:27 ` Alexander Dahl
2025-01-09 16:41 ` Mark Brown
2025-01-10 10:40 ` Alexander Dahl
2025-01-14 17:13 ` Csókás Bence
2025-01-10 7:56 ` Alexander Dahl
2025-01-14 17:21 ` Csókás Bence [this message]
2024-12-17 18:27 ` [PATCH v3 0/2] spi: atmel-quadspi: Refactor to allow supporting SAMA7G5 O/QSPI Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2768b17c-bba8-452c-8148-cfbf1ed5393f@prolan.hu \
--to=csokas.bence@prolan.hu \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=tudor.ambarus@microchip.com \
--cc=varshini.rajendran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®