From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Will Deacon <will@kernel.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux.dev, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, mingyuan.ma@mediatek.com,
yf.wang@mediatek.com, libo.kang@mediatek.com,
chengci.xu@mediatek.com, youlin.pei@mediatek.com,
anan.sun@mediatek.com, xueqi.zhang@mediatek.com,
Guenter Roeck <groeck@chromium.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v5 3/6] iommu/mediatek: Add error path for loop of mm_dts_parse
Date: Mon, 19 Sep 2022 16:20:35 +0200 [thread overview]
Message-ID: <276a4a37-a98d-c59b-a967-db9f5b220077@collabora.com> (raw)
In-Reply-To: <20220919092405.8256-4-yong.wu@mediatek.com>
Il 19/09/22 11:24, Yong Wu ha scritto:
> The mtk_iommu_mm_dts_parse will parse the smi larbs nodes. if the i+1
> larb is parsed fail, we should put_device for the 0..i larbs.
If any v6 will be required... you forgot to update the commit description with
"we should put_device for the i..0 larbs".
>
> There are two places need to comment:
> 1) The larbid may be not linear mapping, we should loop whole
> the array in the error path.
> 2) I move this line position: "data->larb_imu[id].dev = &plarbdev->dev;"
> before "if (!plarbdev->dev.driver)", That means set
> data->larb_imu[id].dev before the error path. then we don't need
> "platform_device_put(plarbdev)" again in probe_defer case. All depend
> on "put_device" of the error path in error cases.
>
> Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with the MM TYPE")
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
In any case....
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2022-09-19 14:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 9:23 [PATCH v5 0/6] iommu/mediatek: Improve safety from invalid dts input Yong Wu
2022-09-19 9:24 ` [PATCH v5 1/6] iommu/mediatek: Add platform_device_put for recovering the device refcnt Yong Wu
2022-09-19 9:24 ` [PATCH v5 2/6] iommu/mediatek: Use component_match_add Yong Wu
2022-09-19 14:20 ` AngeloGioacchino Del Regno
2022-09-19 9:24 ` [PATCH v5 3/6] iommu/mediatek: Add error path for loop of mm_dts_parse Yong Wu
2022-09-19 14:20 ` AngeloGioacchino Del Regno [this message]
2022-09-20 1:28 ` Yong Wu
2022-09-19 9:24 ` [PATCH v5 4/6] iommu/mediatek: Validate number of phandles associated with "mediatek,larbs" Yong Wu
2022-09-19 9:24 ` [PATCH v5 5/6] iommu/mediatek: Improve safety for mediatek,smi property in larb nodes Yong Wu
2022-09-19 9:24 ` [PATCH v5 6/6] iommu/mediatek: Remove unused "mapping" member from mtk_iommu_data Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=276a4a37-a98d-c59b-a967-db9f5b220077@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=anan.sun@mediatek.com \
--cc=chengci.xu@mediatek.com \
--cc=dan.carpenter@oracle.com \
--cc=groeck@chromium.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=libo.kang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mingyuan.ma@mediatek.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=xueqi.zhang@mediatek.com \
--cc=yf.wang@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®