From: Stian Halseth <stian@itx.no>
To: Leon Romanovsky <leon@kernel.org>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
David Miller <davem@davemloft.net>,
Andreas Larsson <andreas@gaisler.com>,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sparc: iommu/pci_sun4v: fix page alignment in dma mapping
Date: Tue, 17 Feb 2026 20:41:32 +0100 [thread overview]
Message-ID: <276c9e7c2e45b4170e102d45066a8892ba33d541.camel@itx.no> (raw)
In-Reply-To: <359aa017-ca72-460d-96dc-c3b46edb186c@app.fastmail.com>
On Tue, 2026-02-17 at 19:52 +0200, Leon Romanovsky wrote:
>
>
> On Tue, Feb 17, 2026, at 19:33, Stian Halseth wrote:
> > Hi Leon,
> >
> >
> > On Tue, 2026-02-17 at 19:25 +0200, Leon Romanovsky wrote:
> > >
> > >
> > > On Tue, Feb 17, 2026, at 19:16, John Paul Adrian Glaubitz wrote:
> > > > Hi Stian,
> > > >
> > > > On Tue, 2026-02-17 at 17:48 +0100, Stian Halseth wrote:
> > > > > Thanks for the review and suggestions.
> > > > >
> > > > > On Tue, 2026-02-17 at 17:38 +0100, John Paul Adrian Glaubitz
> > > > > wrote:
> > > > > > Hi Stian,
> > > > > >
> > > > > > please rephrase the subject to:
> > > > > >
> > > > > > sparc: Fix page alignment in dma mapping
> > > > > >
> > > > > > Your patch is not specific to sun4v but also fixes generic
> > > > > > sparc
> > > > > > code,
> > > > > > so you should remove the part "iommu/pci_sun4v:" from the
> > > > > > subject.
> > > > > >
> > > > > Understood — I will update the patch subject as suggested.
> > > > > > On Tue, 2026-02-17 at 17:21 +0100, stian@itx.no wrote:
> > > > > > > From: Stian Halseth <stian@itx.no>
> > > > > > >
> > > > > > > 'phys' may include an offset within the page, while
> > > > > > > 'base_paddr' is
> > > > > > > already page-aligned.
> > > > > > >
> > > > > > > This caused incorrect DMA mapping in dma_4u_map_phys and
> > > > > > > dma_4v_map_phys.
> > > > > > >
> > > > > > > Fix both functions by masking phys with IO_PAGE_MASK or
> > > > > > > subtracting
> > > > > > > the page offset.
> > > > > >
> > > > > > Please remove the newlines between your sentences, they're
> > > > > > not
> > > > > > necessary
> > > > > > and also trim the lines at 80 columns.
> > > > >
> > > > > Will do — I’ll reformat the commit message to 80-column lines
> > > > > and remove extra newlines.
> > > >
> > > > Perfect! I have nothing to add. Let's have Andreas review your
> > > > patch ;-).
> > >
> > > Please add Fixes line, so the patch will be taken to stable@ in
> > > automatic way.
> > I currently have:
> > Fixes: 38c0d0ebf520 ("sparc: Use physical address DMA mapping")
> >
> > Is this sufficient, or do I need to add something else?
>
> Ohh, you added extra line between signed-of-by and fixes line.
>
> Just remove that extra blank line.
>
> Thanks
Ah, I see what you mean now. There _was_ an extra line in the first
submitted patch [1]. This is not the case in the updated patch v2 [2],
submitted Tue, 17 Feb 2026 17:21:13 +0100.
Let me know if there's still an issue with the latest patch, or if I've
made a mistake when submitting it. My first patch to LKML, sorry about
the extra work :)
>
> > >
> > > Thanks
> > >
> > > >
> > > > Adrian
> > > >
> > > > --
> > > > .''`. John Paul Adrian Glaubitz
> > > > : :' : Debian Developer
> > > > `. `' Physicist
> > > > `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
> >
> > --
> > Best regards
> > Stian Halseth
> >
[1] https://lkml.org/lkml/2026/2/17/845
[2] https://lkml.org/lkml/2026/2/17/908
--
Best regards
Stian Halseth
next prev parent reply other threads:[~2026-02-17 19:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 16:21 stian
2026-02-17 16:38 ` John Paul Adrian Glaubitz
2026-02-17 16:48 ` Stian Halseth
2026-02-17 17:16 ` John Paul Adrian Glaubitz
2026-02-17 17:25 ` Leon Romanovsky
2026-02-17 17:33 ` Stian Halseth
2026-02-17 17:52 ` Leon Romanovsky
2026-02-17 19:41 ` Stian Halseth [this message]
2026-02-17 19:43 ` John Paul Adrian Glaubitz
2026-02-17 17:10 ` [PATCH v2] sparc: Fix " stian
2026-02-18 8:48 ` Leon Romanovsky
2026-02-18 10:28 ` Marek Szyprowski
2026-02-18 11:09 ` Stian Halseth
2026-02-18 11:14 ` Leon Romanovsky
2026-02-18 11:40 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=276c9e7c2e45b4170e102d45066a8892ba33d541.camel@itx.no \
--to=stian@itx.no \
--cc=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=glaubitz@physik.fu-berlin.de \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®