From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70D1628506B for ; Thu, 8 Jan 2026 16:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767889451; cv=none; b=c0dBLX1ks/iKkKDA8y6hz+2BuQpDKtdK76d3vDqHDU92YTaoAddSZ0My1S+yKRBYXRQFmBAJW+tlTgCyeikxN5UKd9FPvkoPcxLu7fG4Do1wrqCDD6JSzjj34MfWt40WbbTRbdg1qTJTTTU3ooRsInxb0DigaC/HjVa5plXu2tA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767889451; c=relaxed/simple; bh=8JTHFk75I11buGH/+77Mor1v6hFhzYcxvXzNsp5vuAA=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=Fn2lME3NM+jydQRpIZd7Q6W/+J9fVoMEFkovaGTEf16uH9cQ3tRJMYpFrzTPyBUCuDiFIpo9AqEy8x5Ns0XWaT9gZEeQg+uOupMC8xnN/456vCfcleH8SN8iSOss/LqkZzLM8XVnJjBFbXfiC+XgBt0Zl/79QgiL8kstog6g/zY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zn3tb28a; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zn3tb28a" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47bdbc90dcaso25162675e9.1 for ; Thu, 08 Jan 2026 08:24:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767889447; x=1768494247; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=Xj3aIiaT0bH4pSRmSIPmDloBNbQZF2Z2t+m5n9HJxGY=; b=zn3tb28alZmOXqfwvMVafCxEEA21If4Qt+aVf9CiLlnx6uN7dbt6s06lyUhTIooGtq nr2cGFthcs2NzUhOX/dLIAWt7wejahCrj1FSsYBbOfw4Ec/3uwiQktNx5EYmvNpzqni7 I1DVV0MyEtBlGYN6BBYFNZrdUHSt7r5lX+wXdOkr7O738H0xSFYgNOVFkdVjo6USvF4I M5P3Iogqm+I56MwQnf8Nq9IWGQcoDKqn0qKVptIkFUxZIGtKh1TBS/B68/aGhcAUHqpq H2feP0JjBd+1hYzQzPh7hXiYg1JlJ6gJsiFAAs1m8OXPAi6p+iiJFGnw6CHmLIcQ/yl6 VNpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767889447; x=1768494247; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xj3aIiaT0bH4pSRmSIPmDloBNbQZF2Z2t+m5n9HJxGY=; b=QIDjJkhsWYmL0qnjTHU2xXbe+kDMCKH+qOAciSqlErdSLFG7cFqeCnx8ZARpoPT1h2 7SAyedITMwKMGlZLvW6pAPC/fgkRq8A7lj4DUbF8QO9uE8IWK/sb/oyGShH7lQpyl91z raW+X0Gx2Xa8CdX8WSpqpen9RfsAvm1bKZqtFNNw94lLeib92fA8kctV20DR0aHj0bXP ozKOniS2nTEfWcSu6YqDDUFSe6TaU0sO5yc7QzIzHhC555Eiande+/PbEZJwSTXjkXQg WciAxn4rkmIyfVj0knmjwRqWWCyMlYsJ9f9WeuNsi5SSL0n86Jurkr5W2teeUkloFFJZ COlA== X-Forwarded-Encrypted: i=1; AJvYcCVaAF9CG2fSLxQ2oDR3dKHDYFfU6A+deAlEOIx5mH3LERFNReaII1Ybii8rk3Uk/TZEgpm3d0FJtJ49HcY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyrcfugf7s6Q3YnS+q6ApoS3TiIo9po2JDK9h/ufpchge3uw9Ml pR66fQzMORZhB8UzqELScsPiJzQ9XQs3RtVLZCipMqnbVyEA+9Y1hYiE+6k3Q1mOQC8= X-Gm-Gg: AY/fxX79mSSKWEY8PMQ5dUm7uYC40iZiYryHSxWTNcYmi5RSs0Dz0Y7rr2V4Mf136je QD1U+vbvRTA1le1yuGSdfAe7HBmUcgUYqKkLz18CWelwK/lD9N+xV4z/eokvZqCHhC7PiFsJUdb HnO3paW+R36yvsTuFp8eU1uGVi5lzP9rn5O4qlapOYAkiioBC+Hymf3nUNICVdlyKew6bPG+Ogt oty8H9d/HdxwtWoiNQt1wMBjFPmlA0WXh2igYIHZ94jEBrDXq5cp5IxF8U8w9tVzJ8XyY3CEN99 CsfP9HASxsewjsz41uOi2pCyscoSWaHEttIQML3M0hTbKcQBzV/MmwKMAHqObayGWEVG/FME9mw KOWGbLMLWBu6vCR5qAx8DzkAEzv4xhTqcFz7kfyvpeM8a1ORczUkOmG3+CMQRNnFuCE2S6Fe6ai 1MpbprNc/DIBsebNfLomtLWlJc6TFroupZIY8pmLP85lqN9zmjdbHBuoMWVvR3G4M= X-Google-Smtp-Source: AGHT+IFtkr+pOe+dymcdTTnpe2tek3vHKNG63sW1D+pxy/ROjygFfnUCBjyfiTcNGWCt+yUnplxx4w== X-Received: by 2002:a05:600c:468e:b0:477:a1a2:d829 with SMTP id 5b1f17b1804b1-47d84b1862cmr87476145e9.13.1767889447411; Thu, 08 Jan 2026 08:24:07 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:2cb0:c864:18bd:9835? ([2a01:e0a:3d9:2080:2cb0:c864:18bd:9835]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f69e802sm164071575e9.8.2026.01.08.08.24.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jan 2026 08:24:06 -0800 (PST) Message-ID: <276fa41c-d575-419d-ae29-ad2acbe7f024@linaro.org> Date: Thu, 8 Jan 2026 17:24:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH] drm/mipi-dsi: add mipi_dsi_shutdown_peripheral_multi To: Avinal Kumar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch References: <20260106112302.204635-1-avinal.xlvii@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260106112302.204635-1-avinal.xlvii@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/6/26 12:21, Avinal Kumar wrote: > Add mipi_dsi_shutdown_peripheral_multi function and mark > mipi_dsi_shutdown_peripheral function as deprecated. > > Signed-off-by: Avinal Kumar > --- > Please refer: https://patchwork.kernel.org/project/dri-devel/patch/20251127161337.396531-1-avinal.xlvii@gmail.com/#26719778 > Build and boot tested with QEMU. > > drivers/gpu/drm/drm_mipi_dsi.c | 28 ++++++++++++++++++++++++++++ > include/drm/drm_mipi_dsi.h | 1 + > 2 files changed, 29 insertions(+) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index a712e177b350..2fed50172a44 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -587,6 +587,9 @@ EXPORT_SYMBOL(mipi_dsi_create_packet); > * mipi_dsi_shutdown_peripheral() - sends a Shutdown Peripheral command > * @dsi: DSI peripheral device > * > + * This function is deprecated. Use mipi_dsi_shutdown_peripheral_multi() > + * instead. > + * > * Return: 0 on success or a negative error code on failure. > */ > int mipi_dsi_shutdown_peripheral(struct mipi_dsi_device *dsi) > @@ -1980,6 +1983,31 @@ void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx, > } > EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_scanline_multi); > > +/** > + * mipi_dsi_shutdown_peripheral_multi() - sends a Shutdown Peripheral command > + * @ctx: Context for multiple DSI transactions > + * > + * Like mipi_dsi_shutdown_peripheral() but deals with errors in a way that > + * makes it convienient to make seeral calls in a row. > + */ > +void mipi_dsi_shutdown_peripheral_multi(struct mipi_dsi_multi_context *ctx) > +{ > + struct mipi_dsi_device *dsi = ctx->dsi; > + struct device *dev = &dsi->dev; > + int ret; > + > + if (ctx->accum_err) > + return; > + > + ret = mipi_dsi_shutdown_peripheral(dsi); > + if (ret < 0) { > + ctx->accum_err = ret; > + dev_err(dev, "Failed to shutdown peripheral: %d\n", > + ctx->accum_err); > + } > +} > +EXPORT_SYMBOL(mipi_dsi_shutdown_peripheral_multi); > + > static int mipi_dsi_drv_probe(struct device *dev) > { > struct mipi_dsi_driver *drv = to_mipi_dsi_driver(dev->driver); > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 3aba7b380c8d..19ccdf5eeb5f 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -389,6 +389,7 @@ void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ctx, > void mipi_dsi_dcs_set_tear_scanline_multi(struct mipi_dsi_multi_context *ctx, > u16 scanline); > void mipi_dsi_dcs_set_tear_off_multi(struct mipi_dsi_multi_context *ctx); > +void mipi_dsi_shutdown_peripheral_multi(struct mipi_dsi_multi_context *ctx); > > /** > * mipi_dsi_generic_write_seq_multi - transmit data using a generic write packet > -- > 2.52.0 > Looks good, please send a multi-patch patchset with "drm/panel: panasonic-vvx10f034n00: transition to mipi_dsi wrapped functions" updated to use this function aswell. If you want to use a simpler way to generate patchsets, please have a look the b4 tool. Neil