From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E75D3E4C70 for ; Thu, 9 Jul 2026 07:36:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783582603; cv=none; b=Afq+fkQIjlwQ08HUUeSXP5ml3mlbm1k5Arye/Etl3pj9XaiiqPnm/1QwK4YXARSR8hrvx5uuDKK7IO5Hq9XneB4ADf+Jw7dRCKUnKaJgiYsOWzV689HWcwGrTdA2dsiJlnnY99PcPK4BXMr1iID+0VFNW9wHYzP2lKO5WdFoOyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783582603; c=relaxed/simple; bh=JXyGcn7soJEOzlyQ4DQohqV6Q/JyLDaj0TwI0NGd+qk=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=GGJCd8ALeZmpezMAzVKnMggtO0z1+XYWGqrp+oLot5c77Y3MCzRmenU1HAXcM6T9bvPNN2sPE3Lsd0GF8u+flsDpxIZYz5U9O6aZ0sEygvOPphFnZ040dFVSdoWkk+32XpqjcZ7vHnY/eIv4ACvSC0qVdeoeOhhAY5Fs2zpWmcY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ursulin.net; spf=pass smtp.mailfrom=ursulin.net; dkim=pass (2048-bit key) header.d=ursulin.net header.i=@ursulin.net header.b=c6U1Q9Eu; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ursulin.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ursulin.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ursulin.net header.i=@ursulin.net header.b="c6U1Q9Eu" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-493ce08a75bso6189245e9.1 for ; Thu, 09 Jul 2026 00:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ursulin.net; s=google; t=1783582597; x=1784187397; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ykv1Gg8TEg7oJaJLPkBJ3p4DRQzUQ1x6/Z28sb6CbPs=; b=c6U1Q9EuCedNpfpaV5z9Env0MfD8jJBw05ih4DDtXLAxN+RYivnJo6n8PeAYKvXnOu DHrvtKwHE7jZoO8p8NDZSCaZDNRDnEOLt8l2mVwIFhn6rn8J5G7CW5e3R5So7lHBiCD5 uahkUmGHoGipKQHgMlcf+feG2N2bW1vCHDfUEQkgLD/4wP02BMUFhVthgmTAPxoi7ZyK CwB8IR+6GbRX6Mp0vG05yG22+YQOjHJyDivGK9zdKGtBBgYWD3S/7txdZtTFMjWzYBUS K8YuFzTvFKPf7kDsRgHDb3XuerhOLVhYebbSTC2lTaV9hv2MON9uqG1eIcJgYJcKjep0 J4Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783582597; x=1784187397; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ykv1Gg8TEg7oJaJLPkBJ3p4DRQzUQ1x6/Z28sb6CbPs=; b=dXyQCO21C246qOQNLxdK5Tw0OV9mo5PU4K30Q3VJmGF3838hrI1NSfLYRQ0BmRFJeo c5SIpGJn54k4jtaHZ5u3dl/TXM3hVJHcOGzh6uE0xyLmDt0o8ZLSQS31k6xJe0buNDa/ xQ3aFy0o3j3Y0ABGPuHtj6R3kjMOaag4qw4y8uM7XmtvZE2/cJn/qhWl+XzzAkibUqFE +FV+Sjyg6NWsiFkq1ECjcgMdt4omU798+ClRIwrJe0e0HtyR+1ELD3RDPIJgZsqSb0Gj QvmtrmT4ypX9ObUyZmrYXzwEYxg+GrJsE7Z4OWyMI0SS4tyM1q256hpeg3pTa+U1/bmy mY5Q== X-Forwarded-Encrypted: i=1; AHgh+RoYzvLw/dir1fwc4HBX6mR6zSFPzCExI1PHcIB28JxXclZgXLNei2wMPu2VbmZtAAePRPZqnFcA8rjdKbk=@vger.kernel.org X-Gm-Message-State: AOJu0YytoX0f9ZFSWrqPWT1ReAz3MOVOdikWfIg+y7f00bs641hvUsSj JihILpG2YK+Vb4Pr8L+DoZKE6MoUMwxATqaZo7H+LLbTBFJgrhc8OgcHLsJ7ROmY2Z8= X-Gm-Gg: AfdE7ckNdBH8Cj0CsZkPHuzNRFgFBe+Qd21WSPKttVP8rONXG8PqBbsvbKSVvsFRzBe 77vyxBXCffMCC19qxFG7Ncs9kEnpRfOGrWvgmXDXZdGZlnKuy4g7x3qodnKaeBa3pTM53/Gj0tX U9z0oZOZBilNvRfdrkAUDSaW2VfblqBz++CdhXRep9cfGLq6aWQdpU8nmWHhtOjhvHVU0RlmrB0 cHD2MdSw5rtFXw1EkmrNMSh+XoK1v2WhhxSqTGc282PFesefg1RnYWK5S1nw2XPGSHb3KaTp3DF 8JMR6GmNGzTQYjRx+0C6hzOENxatvGt2sRuuoCZ9+Vl21PJsJgkRIMUWsaXLEprhJa005xuS0P9 XrimmH9P101J7JzckFEsTZmJb07YBES+AlQhaq8QaW6jyiliAcpmXq0g75hEqaeQ3gD8jjWFrgQ CFyDa2HAcuerz7c5Iy37oE1Sa2FOgIaPQpWA== X-Received: by 2002:a05:600c:3516:b0:492:3e66:6c84 with SMTP id 5b1f17b1804b1-493e68782cdmr58719135e9.30.1783582596744; Thu, 09 Jul 2026 00:36:36 -0700 (PDT) Received: from [192.168.0.116] ([90.240.106.137]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6e0e5asm41503265e9.9.2026.07.09.00.36.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2026 00:36:36 -0700 (PDT) Message-ID: <27702403-4ecb-4f83-ac02-080a689d94a9@ursulin.net> Date: Thu, 9 Jul 2026 08:36:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/i915/gt: use correct selftest config symbol From: Tvrtko Ursulin To: Pengpeng Hou , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Simona Vetter , Thomas Zimmermann Cc: Daniele Ceraolo Spurio , Chris Wilson , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260705080225.436-1-pengpeng@iscas.ac.cn> <6b551a44-96fe-4429-a337-9e6a32ac5156@ursulin.net> Content-Language: en-GB In-Reply-To: <6b551a44-96fe-4429-a337-9e6a32ac5156@ursulin.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 08/07/2026 09:41, Tvrtko Ursulin wrote: > > On 05/07/2026 09:02, Pengpeng Hou wrote: >> intel_engine_user.c checks CONFIG_DRM_I915_SELFTESTS before running >> the engine UABI isolation check. Kconfig defines DRM_I915_SELFTEST, >> without the trailing "S", and the rest of i915 uses >> CONFIG_DRM_I915_SELFTEST. >> >> Because CONFIG_DRM_I915_SELFTESTS is not backed by any Kconfig symbol, >> the IS_ENABLED() test is always false. Use the existing selftest symbol >> so the debug/selftest guarded path can be reached when selftests are >> enabled. >> >> This is a source-level fix. It does not claim dynamic hardware >> reproduction; the evidence is the Kconfig definition and the inconsistent >> guard in intel_engine_user.c. >> >> Fixes: 750e76b4f9f6 ("drm/i915/gt: Move the [class][inst] lookup for >> engines onto the GT") >> Signed-off-by: Pengpeng Hou >> --- >>   drivers/gpu/drm/i915/gt/intel_engine_user.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_user.c b/drivers/ >> gpu/drm/i915/gt/intel_engine_user.c >> index be4bbff1a57c..d5190e11b270 100644 >> --- a/drivers/gpu/drm/i915/gt/intel_engine_user.c >> +++ b/drivers/gpu/drm/i915/gt/intel_engine_user.c >> @@ -259,7 +259,7 @@ >>           p = &prev->rb_right; >>       } >> -    if (IS_ENABLED(CONFIG_DRM_I915_SELFTESTS) && >> +    if (IS_ENABLED(CONFIG_DRM_I915_SELFTEST) && >>           IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) { >>           struct intel_engine_cs *engine; >>           unsigned int isolation; > > Looks correct but we need to have a test run done to see that the checks > this guards actually pass. Please stay tuned for results and please do > ping us in a week or so if we forget. CI was all green. Pushed to drm-intel-gt-next. Thanks, Tvrtko