From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F65238C2C8 for ; Mon, 16 Mar 2026 10:19:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773656351; cv=none; b=tVnDuDk+IvaD9OwlM5mbHV2wjoLDSc7zj1wxEUmghsu1W6c2Po91x+FjP0OgsBfMWUu6XwJThjrQRO1peIQHwDHIkWWfNhCY8Qv9pInXi6KtGPzo9rfpR284SA9wg+tRJhpqN7lG6HeEreFkR2Okyn2Z1Kq+XWuiiFtMMmLHJqo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773656351; c=relaxed/simple; bh=Z3Pv2UF3x1mOPl70WNEH733HqOKkS4/KHiIUlvtl3AI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PQJHzxAjzcDtwE+Dt9iyceKE90fF8YCsnnoZuwBqRkYmGp+AM4TsWl4fXTsH/1ciQ4aLNV3OQrFznYkxqdP2beCV7fxzUYQovHUQuM+iHOk57FLfXPHBEjWY/TIwv4P0WI9Bz3ovboytBXjjWDrDPL3Prj2x2TxDz2TlqJOhtMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=rdMfKQKV; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="rdMfKQKV" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-43b41b545d9so1333365f8f.2 for ; Mon, 16 Mar 2026 03:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1773656347; x=1774261147; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=guiztfKTm/HX0Pn7WIHNBacDDiPf6WW6XQg+TERbbf0=; b=rdMfKQKVYnxv860r2PUuB8YMItsTGqsxuyW6SNBtLRgV4XY9mKKkDE4M2mjXJYxr49 M2gFlBrXDQXDm/OdxVaGIb8fmI5BimkfJrY8sMeRp0Te3eQFG26BlbxMnrGKfQw39BDs POYFNECAVbniVjbZ1YWC6BMaXq1nknq8Pu97aaJN4bqbKyEO+2Yz5SlsOqP48AoR3tOX 2qSmLEeNvzP9O8xFEb85Hmd0ypICGrkj/b7MQUoow6em8+8FXoUtAx40Djce+G0Auh4T n9vHq1DDgB7B6/LW6nnB7XRejyWWhS9MKCUx0RnGzKLHQotkmu9roI/PD5iBxwJ0Oq9P Lqyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773656347; x=1774261147; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=guiztfKTm/HX0Pn7WIHNBacDDiPf6WW6XQg+TERbbf0=; b=dWsSA4fm+q2JvzXw8gKKqwIZLwEpGQnWx/j6hv2jUqlbDp7y6mdRG2opACbdkPDo1y ke+mRmIdiMqRHgUDKqFkLf9YhrB5grAJuSusSJmyN7nW9uOqEDVXoR/gUhnIlgAFUb5P wGMKsiwXdA8qWxjr7T26/q5R53NlN9JYiopPV1pbKUMLVpmKAZMwmUNCGVBJ6C/RBtCV A3O8UU47TE0Fqf3OFhSZ3dRBRLnkKtDtb0Oy2sYBXxmxBfB0TUxojhpsqwEpQG6vrory PVf+Q6A1c3wY9lsAnjE/6RowNGuhoKS4oOlkQGVNpgskC89mDc0/4JpedGnB8DqAJRDj Latg== X-Forwarded-Encrypted: i=1; AJvYcCXEembRNuoxuB+KrFcbDj/3ThAqL1Lvdu5vKkjk+OHXdh6FxzTeMKPO5ZEgR9FJ0/UNwy4bIdV/IBcD7Vc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6FjTzmKzsL+asDMGgjdnazfyqTHs0lloyb/23MDFiHYmp3oA+ oqxXiJkhVJ0TumyQeki7mApFUp23pQDhgJQeYIvsjgSnGGeweoxBfEACIiMQE2JRPKI= X-Gm-Gg: ATEYQzwUhL/v36U5tLqSP7PDBPrW6hZvVtgnoIJ9ZiU8dHM6NdLC9t6TBEH/7K8+W9Y 3ExipMDI7NRem6ykVt8q2FoxzHXTFXP1H3sczNuzfLqlYHIwvmfXZHyAm8saiendAzy2XaYLe8F h4v1yVo+6JSkFcDyLYhPhHWyMnY4bjTmGm2/nTsM1iYXZ08jwqfPaLvGYtg/L4l80kVQgiO0n3Q xjhqZxxEJJaDqal2LjyWCm0JRjZ+snfwXEp/evJGVWUJwQFAshjPTOjRlaFwbK4ve1wDTP1ZNG7 bzk4UcV2BZ7RTCe2r/CHonWGFV6X6cd5dqHM3xMinlpE/maky1isVKBoaSHVM/nVCwMgOK3TjDN Yf3aB9h3U8VdNaXv1O5FdgH39CCZDEbbX5klgU4q3h21pPycDaSfS+Cvjb7tz6d9lFtFGgWgYXy tHkS24wcPzQGIi3j+qXpEg8SyfBsLtR1jpMK0r0zdT7L9utWv1MIYyKpi26RWYWoZvUGr2XI62B l+v/Zc= X-Received: by 2002:a05:600c:49a1:b0:485:4bd1:4c74 with SMTP id 5b1f17b1804b1-4855670c0damr128725525e9.32.1773656347449; Mon, 16 Mar 2026 03:19:07 -0700 (PDT) Received: from ?IPV6:2a02:2f04:6208:0:c5e3:3624:ad1c:6b4? ([2a02:2f04:6208:0:c5e3:3624:ad1c:6b4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48557c6c69fsm93983115e9.26.2026.03.16.03.19.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 03:19:07 -0700 (PDT) Message-ID: <2772d5e1-2127-4808-bd9d-aa40b4ad7104@tuxon.dev> Date: Mon, 16 Mar 2026 12:19:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] pinctrl: renesas: rzg2l: Add GPIO set_config To: Geert Uytterhoeven Cc: linusw@kernel.org, brgl@kernel.org, linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea References: <20260218151925.1104098-1-claudiu.beznea.uj@bp.renesas.com> Content-Language: en-US From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Geert, On 3/13/26 15:15, Geert Uytterhoeven wrote: > Hi Claudiu, > > On Wed, 18 Feb 2026 at 16:19, Claudiu wrote: >> From: Claudiu Beznea >> >> Add GPIO set_config to allow setting GPIO specific functionalities. >> >> Signed-off-by: Claudiu Beznea > > Thanks for your patch! > >> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c >> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c >> @@ -1848,6 +1848,25 @@ static void rzg2l_gpio_free(struct gpio_chip *chip, unsigned int offset) >> rzg2l_gpio_direction_input(chip, offset); >> } >> >> +static int rzg2l_gpio_set_config(struct gpio_chip *chip, unsigned int offset, >> + unsigned long config) >> +{ >> + switch (pinconf_to_config_param(config)) { >> + case PIN_CONFIG_BIAS_DISABLE: >> + case PIN_CONFIG_BIAS_PULL_UP: >> + case PIN_CONFIG_BIAS_PULL_DOWN: >> + case PIN_CONFIG_DRIVE_OPEN_DRAIN: >> + case PIN_CONFIG_DRIVE_PUSH_PULL: >> + case PIN_CONFIG_SLEW_RATE: >> + case PIN_CONFIG_DRIVE_STRENGTH: >> + case PIN_CONFIG_DRIVE_STRENGTH_UA: >> + case PIN_CONFIG_POWER_SOURCE: > > Shouldn't you handle all types that are supported by > rzg2l_pinctrl_pinconf_[gs]et()? > > The following are missing: > PIN_CONFIG_INPUT_ENABLE > PIN_CONFIG_OUTPUT_ENABLE > PIN_CONFIG_OUTPUT_IMPEDANCE_OHMS > PIN_CONFIG_INPUT_SCHMITT_ENABLE > RENESAS_RZV2H_PIN_CONFIG_OUTPUT_IMPEDANCE I'll add these as well. Thank you for your review, Claudiu