From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.11.138.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792520686; b=iSJIHx0DVSInRKesnOewv9sb2CyX2VYKyh7ViJtEbu+V1Yojl9DiVsJ4HKUKtje2b+pQ Hrc67swftLbipit37Ooa+VO4+/K0VHixLhXiqBjsCqas/Asezsv7LPjRmtwpM9nTgSaFn BMDq2UWpkd1VGV0jTE6uVCWcIyttn5nbSfmdvoM5SAMGdfqzVtCaijzRe1ti6djVjDoBN JJXypQy9TDKk24m+foLePwprXhLtI9gXqh7ZIyBsJHb4Kg3U8Vkfm/ZKR+8AslgyqG7Mr mJqXR7+fdUsmRi+TBlVDp5WTrPxRw+BNOnXhjKI7kEtUJoXtiksHtTzfVxj9QCc1smw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792520686; h=DMARC-Filter:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding: Content-Type; bh=JtJbWi9XblqGf/oBFuSjQ+CThYnu2eCXkRHoK4PJRfI=; b=OFo8D/DpzJMcJu4jbAoftWlIS3l/k9MeVx/2+O5Neh60VhrlaHx6JSahskIxmcdqEZGd Lm/YRvJjLEm8awhkiwtmzZTjmJuQxHAmCgUxzyDqSZHe3j3e1lm3DPx6Sm/nRP6WOenyJ 28m+XrTmtCXdQPLIPg4n2peMA3GXPd3Q/uCnWUsphuVkl72JZ2kqWhn5SIox5fT8gBOrN DkVZ2OL/IOvynt1ZktmvctvoyEHqtJHjyn7yhmvDIjXxP/Lg75oyGvcwhhf6GzxhG0jb0 rcVVd4C+ZxAtU5xYJuZwc58w6Ohkfwrw7Eom1Ku7g9Na7Rp84jcXmNV++t6kqoM0PYw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; arc=none smtp.remote-ip=185.11.138.130 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F370606A31C; Tue, 20 Oct 2026 18:24:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4F370606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=JtJbWi9XblqGf/oBFuSjQ+CThYnu2eCXkRHoK4PJRfI=; b=BEt9j0U6juqDHsTxevzqy6Cbwj ZhdZHc8X2xr8Y0EjV/ex/W3jqfYBfr5aT0wdoMG+sMeIzYq+rrc6VORSsNunbuqoLYGyCPfpOz6Y1 G8Ii0CAgrY5R/3CCWgfyzJss4+Kc+D/ALPzaherJ2GbCmS5zJcZxXnm4/nLh17rCKEPdNqb6RVMe1 8naKvOPt12qJv8rSaMd+YtIEWf9GWLhFywOGIR72ZqBwAq/hsgbhnmzP8FUJhWWQsw1Xiy1E4qjlF sMZrCh25Muyv8QgvFd+a5G6vR73nYS+VTLNaiyKoCE58dXw8bRwb9IC8prm9g7zbNBVRToteZOgH/ fyHjy4bQ==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Rob Herring , Michael Riesch Cc: =?UTF-8?B?5qWK5pm65oiQ?= , Krzysztof Kozlowski , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley , Guochun Huang , Philipp Zabel , Sebastian Reichel , Bryan O'Donoghue , linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/8] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: Add a cell to select TX or RX Date: Tue, 20 Oct 2026 20:24:22 +0200 Message-ID: <2778734.k3LOHGUjKi@diego> In-Reply-To: <94d47cab-10c6-4ec3-84a0-3bddc9d67f5f@collabora.com> References: <20261016-dcphy-rx-v1-v5-0-e63b49eabe2d@gmail.com> <25254818.ouqheUzb2q@diego> <94d47cab-10c6-4ec3-84a0-3bddc9d67f5f@collabora.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi Michael, Am Dienstag, 20. Oktober 2026, 20:04:33 Mitteleurop=C3=A4ische Sommerzeit s= chrieb Michael Riesch: > On 10/20/26 16:57, Heiko St=C3=BCbner wrote: > > Am Dienstag, 20. Oktober 2026, 16:10:39 Mitteleurop=C3=A4ische Sommerze= it schrieb Rob Herring: > >> On Tue, Oct 20, 2026 at 03:37:35PM +0200, Heiko St=C3=BCbner wrote: > >>> Am Dienstag, 20. Oktober 2026, 00:20:47 Mitteleurop=C3=A4ische Sommer= zeit schrieb Michael Riesch: > >>>> Hi all, > >>>> > >>>> On 10/19/26 17:06, Rob Herring wrote: > >>>>> On Mon, Oct 19, 2026 at 04:15:03PM +0800, =E6=A5=8A=E6=99=BA=E6=88= =90 wrote: > >>>>>> Hi Krzysztof, Rob, > >>>>>> > >>>>>>> Existing OS should ignore surplus cell if the driver is coded pro= perly. > >>>>>>> Same as adding new properties or new front-compatible. The quest= ion is > >>>>>>> how the existing driver behaves? > >>>>>> > >>>>>> As you pointed out on 5/8, the xlate checks args_count !=3D 1. The= DC-PHY > >>>>>> driver was merged in v6.15, so every kernel since 6.15 fails on a = second cell. > >>>>>> > >>>>>> 1. Keep the second cell. Add the patch as follows: > >>>>>> > >>>>>> - if (args->args_count !=3D 1) { > >>>>>> + if (args->args_count < 1) { > >>>>>> dev_err(dev, "invalid number of arguments\n"); > >>>>>> return ERR_PTR(-EINVAL); > >>>>>> } > >>>>>> > >>>>>> + if (args->args_count > 1 && args->args[1]) { > >>>>>> + dev_err(dev, "only the transmitter is supported\n"); > >>>>>> + return ERR_PTR(-EINVAL); > >>>>>> + } > >>>>>> > >>>>>> With Fixes: and Cc: stable, the stable kernels maintained at that > >>>>>> time (currently 6.18.y and 7.2.y) keep DSI working with the new > >>>>>> dts, and the receiver fails cleanly instead of getting the trans= mitter. > >>>>>> But EOL kernels (6.15, 6.16, 6.17, 6.19, 7.0, 7.1) stay affected. > >>>>>> It goes in with the series, since two-cell dts only exist after = it. > >>>>>> > >>>>>> 2. Use a flag in the upper bits of the existing cell, as Rob > >>>>>> suggested. Existing kernels are not affected, unless a board e= nables > >>>>>> the DC-PHY CSI-2 receiver on 7.0 or later without this series. > >>>>>> > >>>>>> I will write the impact clearly whichever approach is selected in > >>>>>> the related commit messages and the cover letter. > >>>>>> > >>>>>> I think the cell approach is easier to read and more symmetric in = the > >>>>>> long term, > >>>>>> but it breaks more. Which one do you think is better? Thanks. > >>>>> > >>>>> I'm not a user of this platform, so I don't care. Up to the platfor= m=20 > >>>>> maintainers to decide if breakage is acceptible. You just need to=20 > >>>>> document the issue in the commit message. > >>>>> > >>>>> Rob > >>>> > >>>> It's a bit of a pickle, all this. > >>>> > >>>> I gave it some more thought. In the end this is an IP block with two > >>>> PHYs. No more, no less. One cell is sufficient to address those, and= it > >>>> could be 0 for the transmitting PHY (DSI, display) and 1 for the > >>>> receiving PHY (CSI, camera). > >>>> > >>>> Of course the two PHYs can operate in either DPHY or CPHY mode. The > >>>> phy-cells have been (mis?)used to select the proper mode of combo PH= Ys, > >>>> and this principle has been applied here too. > >>>> > >>>> However, we have the special situation here that the mode can only be > >>>> changed for the complete IP block (and thus for both PHYs at the same > >>>> time). As Bryan points out, we need to check and complain if the PHY > >>>> mode is not set to the same value for both PHYs. > >>>> > >>>> I suggest using a property > >>>> samsung,cphy-mode; > >>> > >>> I guess, a maybe nicer way would be mimicing > >>> Documentation/devicetree/bindings/phy/intel,combo-phy.yaml > >>> > >>> with its > >>> intel,phy-mode =3D > >>> > >>> with x coming from include/dt-bindings/phy/phy.h > >>> for the distinction between cphy and dphy, so we don't introduce yet > >>> another way to describe this. > >> > >> We already have the plain 'phy-type' property which takes the same=20 > >> PHY_MODE_x values. We don't need yet another vendor specific property. > >=20 > > even better then ... and I didn't look deep enough it seems. > >=20 > >=20 > >>>> (name to be bikeshedded) that sets the complete IP block into CPHY m= ode > >>>> (DPHY being the default) to distinguish between the modes. Since both > >>>> modes use a different electrical interface, this is clearly a hardwa= re > >>>> thing and thus suitable for device tree. > >>>> > >>>> Then, we can address the two PHYs with the help of the already exist= ing > >>>> phy cell (without any bitflag tweaks to the value). > >>>> > >>>> The sole drawback is that we need to accept the PHY_TYPE_DPHY and > >>>> PHY_TYPE_CPHY values that some OS in the field might pass. (For Linu= x, > >>>> it should only be the former.) And we need to handle those values > >>>> correctly. But I think this is not more painful than the other > >>>> approaches. At the same time, this design seems to be the most corre= ct > >>> > >>> The current cell values are 10 + 11, so as long as we don't re-use th= ose > >>> exact values for the other constants the driver should somewhat easily > >>> be able to recognize an old DT? > >> > >> I think you will still have an ABI issue of what does old OS do with n= ew=20 > >> values? > >=20 > > wasn't the main contract, a newer kernel should support old DTs ? > >=20 > > Aka the DT is parked in some firmware part (u-boot?) and gets handed > > to the newer kernel. > >=20 > > I don't see deliberately handing a newer DTB to an older kernel as a > > very common occurence? > >=20 > >=20 > > And from a practical standpoint: > >=20 > > We're talking about devices with DSI displays that are at stake here, > > so we're in the embedded world. > >=20 > > In other areas we're still fighting basic functionality like actually > > handling the type-c orientation correctly in the usbphy. > >=20 > > So I really don't see a device with a user-updateable mainline kernel o= ut > > in the field, apart from people hacking around on their devices to try > > out new features and new kernels, simply because core functionality > > is still evolving in mainline. > >=20 > >=20 > > RK3576/RK3588 devices still ship with a vendor u-boot/kernel, with > > completely incompatible DTB afterall. > >=20 > >=20 > > So yes, supporting old devicetrees on new kernels I do see as important > > but someone working extra hard to combine a new DT with an old kernel, > > I really don't see as an issue here. > > >=20 > Just to make sure I understood it correctly: the current suggestion > would be the standard integer property (optional) >=20 > phy-type: > description: D-PHY (default) or C-PHY mode > enum: > - 10 # PHY_TYPE_DPHY > - 11 # PHY_TYPE_CPHY > default: 10 >=20 > plus changing phy-cells to: >=20 > "#phy-cells": > const: 1 > description: | > Argument defines whether receiver or transmitter PHY is used. > - PHY_DIRECTION_TX > - PHY_DIRECTION_RX > See include/dt-bindings/phy/phy.h for constants. >=20 > plus handling the case where an old DTS may still have a line >=20 > phys =3D <&mipidcphy0 PHY_TYPE_DPHY>; >=20 > and the new kernel will convert it to something equal to phy-type =3D > PHY_TYPE_DPHY and phys =3D <&mipidcphy0 PHY_DIR_TX>; >=20 > plus ignoring the whether or not an old kernel can work with a new DTS > or not. >=20 > By the way, if we handle the case of the old DTS with the new kernel > correctly (which we should IMHO) then we do not need to change the > existing DTS nodes, thus eliminating regressions. >=20 > Is this summary correct? Yep, that's what I had in mind ... though dependent on DT-maintainers not disagreeing on the reasoning ;-) Heiko