mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: simran singhal <singhalsimran0@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: light: constify attribute_group structures
Date: Sat, 1 Apr 2017 11:41:06 +0100	[thread overview]
Message-ID: <277e5ae4-5154-547a-147c-9fee105ba5a6@kernel.org> (raw)
In-Reply-To: <20170401022856.GA9305@singhal-Inspiron-5558>

On 01/04/17 03:28, simran singhal wrote:
> As the event_attrs field of iio_info structures is constant, so these
> attribute_group structures can also be declared constant.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>   15064	   1528	      0	  16592	   40d0
> drivers/staging/iio/light/tsl2x7x_core.o
> 
> File size after:
>    text	   data	    bss	    dec	    hex	filename
>   15192	   1400	      0	  16592	   40d0
> drivers/staging/iio/light/tsl2x7x_core.o
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
Not a big thing, but as this only touches the one driver, i would have
liked that mentioned in the naming of the patch...

I've added it.
Applied.
> ---
>  drivers/staging/iio/light/tsl2x7x_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
> index 0490c1d..9a0046a 100644
> --- a/drivers/staging/iio/light/tsl2x7x_core.c
> +++ b/drivers/staging/iio/light/tsl2x7x_core.c
> @@ -1676,7 +1676,7 @@ static const struct attribute_group tsl2X7X_device_attr_group_tbl[] = {
>  	},
>  };
>  
> -static struct attribute_group tsl2X7X_event_attr_group_tbl[] = {
> +static const struct attribute_group tsl2X7X_event_attr_group_tbl[] = {
>  	[ALS] = {
>  		.attrs = tsl2X7X_ALS_event_attrs,
>  		.name = "events",
> 

      reply	other threads:[~2017-04-01 10:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01  2:28 simran singhal
2017-04-01 10:41 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=277e5ae4-5154-547a-147c-9fee105ba5a6@kernel.org \
    --to=jic23@kernel.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=singhalsimran0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®