From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65F00211463 for ; Tue, 14 Jan 2025 22:03:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736892195; cv=none; b=AjUf7c32oHAnX+vtnBUNAwYdWlbjmBDeo3TFypkzJ93F9qo86MY6nUI1dGtSytycy9ban+6wFsMHoWShRWugC9PhpuxUT+8E98KcjnQeeswIIZd/NQ06VqBoYd1iA0zGDiUvW4JkLibjEu55+Gfkxj5zJV/l7X3X3PPyYKd/QN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736892195; c=relaxed/simple; bh=iEB24mPXNOnmMhT7GqF5V2mxlZjcp6Sc1TJS8/Wv0qE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q3vlZheraV2qNjqP+Fwy2MMxaYwpKjX24PC+V+PgS1binQY+xeZuyb9ZGfGSmFPTZevHHV+8RgIpGASiBzAgBiwfDh824BK8t0Y8saOh9MirKpdjPWIhMyPn2wx8KwOT6QI6M1a28TakUzT4g6zeCyXQEDxN/tQXLpdG15yBL1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ODg8DI+o; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ODg8DI+o" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736892192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+MvD4M913WVwzsF4WAIrvgtMmoaIS9H8PUn1UYGTDYw=; b=ODg8DI+oHmlWulaLqXV60J0sosKtVj2w+irZhEMEFFo20M29+R6/PX2//iRz6l/9WRbNgj dwdh0q2AuDNkVDRSGDhPRFxPJylkwL0w9TGMwKGlX3s2nlCr0QpZaZq5aiBv55fXgEP/w/ Oy6gTlJmaoMFJsdR1UzqO0UNYvGt7e4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-SMrI2_B2PTyp5WTUf8j90w-1; Tue, 14 Jan 2025 17:03:10 -0500 X-MC-Unique: SMrI2_B2PTyp5WTUf8j90w-1 X-Mimecast-MFC-AGG-ID: SMrI2_B2PTyp5WTUf8j90w Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4361fc2b2d6so33689595e9.3 for ; Tue, 14 Jan 2025 14:03:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736892189; x=1737496989; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+MvD4M913WVwzsF4WAIrvgtMmoaIS9H8PUn1UYGTDYw=; b=cSdcqlwDvgmnawPDGo4PoRZq9U+qbTNoj3SZ7tpuz5iUDf2JgO2Vj90tOS2QBHL8Tw 4AYlfpEBiLc3MN8nZ9Skr59KU26tkUYbM1XjKRtgwjwWn4B0yVxl1PrNYoQSUimAag49 iCqOR6XV9u5j8KZm5ce6zvvpNOSMnQqOQgltrEOJZS6HN8KPSUSK0oEP4LA7LRnQgU0L 2IJI/tlw6Osf5/jm7fTF3fiMMWzB9tdxSh9vDz2LVp49/tAUkqfJ7x6UFSJKGoHy9l4h QRONBC3iCzihcip+WXob9MyZGyq4xNag82spxrzaFIvIqRDozP3j9CiElzEa6kQ2f+Be eEOg== X-Forwarded-Encrypted: i=1; AJvYcCVXUiG7yJwKAfB/cTqB0HSqa0z3oPAax9L5tHpEJx1Cf71E+CG2A+He8qly5kWid6RulCkczzxifbBGngA=@vger.kernel.org X-Gm-Message-State: AOJu0YymD2+STdTGmXNte42AFA+YKrlb393Yk0q4QopgWOwDG3HPNEx0 lJv+ORGA6kC1lTD0vrp4fY2HcNfUYWhLlk0RbMQABm99m5ESxrXoEhaLLJtVJuM9oyP9cw/uNRx XjOhXQn/yv3dXRB5Nxq9SUR5RUXSpOo+oe3mcLO5hvjduQX4K4mkShTobuc7VIw== X-Gm-Gg: ASbGncteW1PFnYO7S4AX4V7YvKnD2ZEHVSU7KAjWm7tFMCg74Y0LUV04PfrNZxjGpsm Yq6ACeGhQLO6e7UxAxIYFMBxOm0oYzIHk1koas+VJbxbt0+klTN9KM5S1wQRFai7fixaGCWxxeN SY/Yiw/V17qjHw3ezcaPH4c7Imcbwpn3i7rRk5RkDVekPzNbKvZPwDMkUOPKlkSAthZR7n1WRqS 6BlFFClvFtgNClsWMh35O9rmj5Mk/l/sy9cc/hjyJwu4rW0UniyZN4djMW6 X-Received: by 2002:a05:600c:314f:b0:435:9ed3:5688 with SMTP id 5b1f17b1804b1-436e26a1f79mr269319315e9.18.1736892189446; Tue, 14 Jan 2025 14:03:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IGKm8hhQYE4+E8qiCVhc4G2fcvrymf8/h3v8oo+/TYX5mviQN0KPyQ/jqniImUNBbtDn40Pjg== X-Received: by 2002:a05:600c:314f:b0:435:9ed3:5688 with SMTP id 5b1f17b1804b1-436e26a1f79mr269319155e9.18.1736892189037; Tue, 14 Jan 2025 14:03:09 -0800 (PST) Received: from [192.168.10.3] ([176.206.124.70]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-437c74bf02csm873935e9.17.2025.01.14.14.03.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 14:03:08 -0800 (PST) Message-ID: <277eeb7b-325e-4901-a466-09708560aee5@redhat.com> Date: Tue, 14 Jan 2025 23:03:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/13] x86/virt/tdx: Add SEAMCALL wrappers for TD measurement of initial contents To: "Edgecombe, Rick P" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Zhao, Yan Y" , "sean.j.christopherson@intel.com" , "Huang, Kai" , "dave.hansen@linux.intel.com" , "Yamahata, Isaku" References: <20250101074959.412696-1-pbonzini@redhat.com> <20250101074959.412696-12-pbonzini@redhat.com> From: Paolo Bonzini Content-Language: en-US Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/3/25 19:02, Edgecombe, Rick P wrote: >> +u64 tdh_mr_extend(struct tdx_td *td, u64 gpa, u64 *rcx, u64 *rdx) > > gpa should be type gpa_t to avoid bare u64 types. gpa_t is defined in kvm_types.h, I am not sure arch/x86/virt should include it. Paolo