From: "Arnd Bergmann" <arnd@arndb.de>
To: "Dawei Li" <dawei.li@shingroup.cn>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Serge Semin" <fancer.lancer@gmail.com>,
"kernel test robot" <lkp@intel.com>,
linux-kernel@vger.kernel.org, "Dawei Li" <set_pte_at@outlook.com>
Subject: Re: [PATCH v2] misc: eeprom/idt_89hpesx: Convert data structures to LE explicitly
Date: Wed, 14 Feb 2024 11:17:06 +0100 [thread overview]
Message-ID: <2780b965-02fe-41fd-ae16-98f7619aeed2@app.fastmail.com> (raw)
In-Reply-To: <20240131033028.3099156-1-dawei.li@shingroup.cn>
On Wed, Jan 31, 2024, at 04:30, Dawei Li wrote:
> Kernel test robot reports following sparse warnings:
>>> drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse: sparse:
> incorrect type in assignment (different base types) @@
> expected unsigned short [addressable] [assigned] [usertype]
> memaddr @@ got restricted __le16 [usertype] @@
>
> drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse:
> expected unsigned short [addressable] [assigned] [usertype]
> memaddr
>
> drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse:
> restricted __le16 [usertype]
>
> .....
>
> For data structures needs cpu_to_le* conversion, their prototype need
> to be declared with __le* explicitly.
>
> Declare data structures to __le* explicitly to address the issue:
> - struct idt_eeprom_seq::memaddr
> - struct idt_csr_seq::csraddr
> - struct idt_csr_seq::data
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202401261250.b07Yt30Z-lkp@intel.com/
> Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
> Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2024-02-14 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 3:30 Dawei Li
2024-02-14 10:05 ` Dawei Li
2024-02-14 10:17 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2780b965-02fe-41fd-ae16-98f7619aeed2@app.fastmail.com \
--to=arnd@arndb.de \
--cc=dawei.li@shingroup.cn \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=set_pte_at@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®