From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753969AbcB2Ofq (ORCPT <rfc822;w@1wt.eu>);
	Mon, 29 Feb 2016 09:35:46 -0500
Received: from mout.kundenserver.de ([212.227.126.187]:49798 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752788AbcB2Ofm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 29 Feb 2016 09:35:42 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Michal Marek <mmarek@suse.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lz4c: shut up lz4c output
Date: Mon, 29 Feb 2016 15:35:09 +0100
Message-ID: <2781274.5SXPMrqOdg@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <56D44065.4070005@suse.com>
References: <1456749618-1067584-1-git-send-email-arnd@arndb.de> <56D44065.4070005@suse.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:PjE88Gnhkfnbzbm0wmM8fdvMyIoRgpFX2olHVG0dUlfHBamHgUW
 jT+8oOD4hpSXtvZAUEGGQfRwcYKbIuU6htyG325w8Y2B4El/eP6ELf+WNoSdhuzc4ObIfiS
 IE5K+TreJp0SCDW+wyRkkmQ0lCHdpDnHi+FHw2UTd0Q0J3JQLIOS1+fPnD+6xtnEVhu5QRY
 HFfLm9S2giFCc7I25mwHQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:C4FDjxKgQR0=:VwWfR99BAyF1sdUKxXgl6s
 wmHC0o3rS4/kn0Doa0gHtI0HZIWZc5lyMMqGjYIhNMgRvLorPka9mN1hrpwDg655P5LhTLgFa
 /iSWziltOt2YlDjXLQ4FmJyjZWnQujEW/9DNJiVnHrH53julzoek5Vsxl1/Yf4zzu2ZJeI1d9
 EeuMOMS2q6mAlLUZKOZTjlB3tO9rc7dDS0hM2EciIzqyaqqKTG5u/k9Rud2IQDdm11HjCkIdM
 49nqQyjiHNPis8boFg8cf/sBJAlFdPgeguB/YEqy5R03B9y3QPIenz7nTg7X0H3S3xh/ct9sk
 VjXeqKoB4s3Of/2tzoOQ5yfwDhJbiJplM83k3Twc3ShVoDLxtUcD+60Bb/hNb7V5OU9juk9aU
 Lx7CIT+sPcoboLVmQd8eExxSGWonAA+L3LRVHSdvsyvj2kXmLMxbVdktPS9saPD2kcaB4zkuC
 Y4R0hGBwpofeGgEedubMrlWiauBe9izcWSu6aX1+OS/uxL4Apl9RBR6xiCJrfc4f0ZwDDkfhI
 87cxPm1l/HQ/8bnslo8AxTOhHPVEjqiVijn5ReOUEqHVM7RC/D0DRaVwYNYWQ8OwsHO2WgdAF
 kknaaU2IA7vGwcifQlY08SPOv4XANgl/80HgtqtUB7Gszq6vfETZwoDc9p1Vvp1d//H7vzA8x
 yxPGY2xbo7P73LfWVboUJlSpM53F+kTrZyM0Nxylwy9/SvdFedbK9EsScIG5zQBOZwHnLdQ7B
 umkiha36GhltVdXB
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday 29 February 2016 13:58:13 Michal Marek wrote:
> On 2016-02-29 13:40, Arnd Bergmann wrote:
> > When KERNEL_LZ4 is set, we always get an output even when building
> > with 'make -s':
> > 
> >     *** LZ4 Compression CLI , by Yann Collet (May 31 2013) ***
> >     ! Generating compressed LZ4 using Legacy format (deprecated !) !
> >     Using stdin for input
> >     Using stdout for output
> >     Compressed 11213376 bytes into 4555781 bytes ==> 40.63%
> >     Done in 0.63 s ==> 16.97 MB/s
> > 
> > The output is not helpful in the context of building the kernel,
> > so this patch hides the stdout output of the lz4 binary completely.
> 
> > -     lz4c -l -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \
> > +     lz4c -l -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ 2>&1 || \
> >       (rm -f $@ ; false)
> 
> Hi Arnd,
> 
> this redirection does not hide it, but rather includes it in the
> compressed image file.

Oops, you are right. I was cleaning out some older patches I had in my
queue and hadn't realized it was completely botched this way.

> BTW, my copy of lz4c only displays this warning with -v.

I've updated my copy of lz4c now and can confirm that the output
is completely gone (without -v). I won't follow up with a fixed version
then, as the problem is already solved elsewhere.

	Arnd