From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751391AbdH1RsV (ORCPT ); Mon, 28 Aug 2017 13:48:21 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:25464 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161AbdH1RsU (ORCPT ); Mon, 28 Aug 2017 13:48:20 -0400 Subject: Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early in boot To: Thomas Gleixner Cc: x86@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, hpa@zytor.com, douly.fnst@cn.fujitsu.com References: <1503520884-99253-1-git-send-email-pasha.tatashin@oracle.com> <1503520884-99253-2-git-send-email-pasha.tatashin@oracle.com> <2d5087a2-2aca-aaba-4608-112facbd3208@oracle.com> From: Pasha Tatashin Message-ID: <27816ace-bbc2-ccad-d2db-c4804a61ebe3@oracle.com> Date: Mon, 28 Aug 2017 13:47:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> And because its called only once, it does not need to be marked __init() >>> and must be kept around forever, right? >> >> This is because every other architecture implements read_boot_clock64() >> without __init: arm, s390. Beside, the original weak stub does not have __init >> macro. So, I can certainly try to add it for x86, but I am not sure what is >> the behavior once __init section is gone, but weak implementation stays. > > And what about fixing that everywhere? > Sure, I will update it everywhere.