From: Valdis.Kletnieks@vt.edu
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
James Morris <jmorris@namei.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] SELinux: change Kconfig to use select instead of depends
Date: Wed, 10 Oct 2007 15:53:02 -0400 [thread overview]
Message-ID: <27818.1192045982@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Wed, 10 Oct 2007 08:40:31 PDT." <470CF26F.10606@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
On Wed, 10 Oct 2007 08:40:31 PDT, Randy Dunlap said:
> >>> config SECURITY_SELINUX
> >>> bool "NSA SELinux Support"
> >>> - depends on SECURITY_NETWORK && AUDIT && NET && INET
> >>> + depends on SECURITY
> >>> + select SECURITY_NETWORK
> >>> + select AUDIT
> >>> + select NET
> >>> + select INET
> >>> select NETWORK_SECMARK
> AUDIT isn't quite library code, still I don't have a (big) problem with
> selecting it or NETWORK_SECMARK. (other than select is evil :)
>
> OTOH, NET and INET are large config options, not library-like code, and
> should not be selected.
If it does a 'select SECURITY_NETWORK' but NET=n, does the resulting kernel
actually build? The problem seems to be that select isn't transitive - if
you select something, it won't automagically select that something's pre-reqs
(modulo the recent patches I've seen posted, have those been mainlined?).
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
next prev parent reply other threads:[~2007-10-10 19:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 23:18 [PATCH 0/6] SELinux patches for 2.6.24 James Morris
2007-10-09 23:19 ` [PATCH 1/6] SELinux: change Kconfig to use select instead of depends James Morris
2007-10-09 23:28 ` Randy Dunlap
2007-10-09 23:50 ` James Morris
2007-10-10 0:16 ` Randy Dunlap
2007-10-10 12:12 ` Stephen Smalley
2007-10-10 15:40 ` Randy Dunlap
2007-10-10 19:53 ` Valdis.Kletnieks [this message]
2007-10-10 19:57 ` Randy Dunlap
2007-10-09 23:20 ` [PATCH 2/6] SELinux: tune avtab to reduce memory usage James Morris
2007-10-09 23:21 ` [PATCH 3/6] SELinux: Improve read/write performance James Morris
2007-10-09 23:22 ` [PATCH 4/6] SELinux: policy selectable handling of unknown classes and perms James Morris
2007-10-09 23:23 ` [PATCH 5/6] SELinux: improve performance when AVC misses James Morris
2007-10-09 23:23 ` [PATCH 6/6] SELinux: kills warnings in Improve SELinux " James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27818.1192045982@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sds@tycho.nsa.gov \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®