Fwd: After kernel 6.3.7 or 6.3.8 b43 driver fails

[Bagas Sanjaya <bagasdotme@gmail.com>]

Hi,

I notice a regression report on Bugzilla [1]. Quoting from it:

> After upgrading to linux 6.3.8-arch1-1 from 6.3.6-arch1-1, b43 broadcom wireless driver fails.  downgrading back to 6.3.6-arch1-1 resolves.
> 
> Jun 16 20:56:37 askasleikir kernel: Hardware name: Apple Inc. MacBookPro7,1/Mac-F222BEC8, BIOS MBP71.88Z.0039.B15.1702241313 02/24/17
> Jun 16 20:56:37 askasleikir kernel: Workqueue: phy0 b43_tx_work [b43]
> Jun 16 20:56:37 askasleikir kernel: RIP: 0010:__ieee80211_stop_queue+0xcc/0xe0 [mac80211]
> Jun 16 20:56:37 askasleikir kernel: Code: 74 11 48 8b 78 08 0f b7 d6 89 e9 4c 89 e6 e8 5b eb 00 00 65 ff 0d 0c dd b5 3e 0f 85 55 ff ff ff e8 b9 f4 12 de e9 4b ff>
> Jun 16 20:56:37 askasleikir kernel: RSP: 0000:ffffc36b0013bdb8 EFLAGS: 00010097
> Jun 16 20:56:37 askasleikir kernel: RAX: 0000000000000001 RBX: 0000000000000002 RCX: 0000000000000000
> Jun 16 20:56:37 askasleikir kernel: RDX: 0000000000000000 RSI: 0000000000000002 RDI: ffff9f85d1c108e0
> Jun 16 20:56:37 askasleikir kernel: RBP: 0000000000000000 R08: 0000000000000000 R09: ffff9f85c0819674
> Jun 16 20:56:37 askasleikir kernel: R10: 0000000000000005 R11: 0000000000000181 R12: ffff9f85d1c108e0
> Jun 16 20:56:37 askasleikir kernel: R13: 0000000000000000 R14: ffff9f85d1c12238 R15: ffff9f85d1c12090
> Jun 16 20:56:37 askasleikir kernel: FS: 0000000000000000(0000) GS:ffff9f85fbe00000(0000) knlGS:0000000000000000
> Jun 16 20:56:37 askasleikir kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> Jun 16 20:56:37 askasleikir kernel: CR2: 000055b33bbd5d70 CR3: 0000000022620000 CR4: 00000000000406f0
> Jun 16 20:56:37 askasleikir kernel: Call Trace:
> Jun 16 20:56:37 askasleikir kernel: <TASK>
> Jun 16 20:56:37 askasleikir kernel: ? __ieee80211_stop_queue+0xcc/0xe0 [mac80211 136d1d948548ad6cca697df0da0a13c0a2333310]
> Jun 16 20:56:37 askasleikir kernel: ? __warn+0x81/0x130
> Jun 16 20:56:37 askasleikir kernel: ? __ieee80211_stop_queue+0xcc/0xe0 [mac80211 136d1d948548ad6cca697df0da0a13c0a2333310]
> Jun 16 20:56:37 askasleikir kernel: ? report_bug+0x171/0x1a0
> Jun 16 20:56:37 askasleikir kernel: ? handle_bug+0x3c/0x80
> Jun 16 20:56:37 askasleikir kernel: ? exc_invalid_op+0x17/0x70
> Jun 16 20:56:37 askasleikir kernel: ? asm_exc_invalid_op+0x1a/0x20
> Jun 16 20:56:37 askasleikir kernel: ? __ieee80211_stop_queue+0xcc/0xe0 [mac80211 136d1d948548ad6cca697df0da0a13c0a2333310]
> Jun 16 20:56:37 askasleikir kernel: ieee80211_stop_queue+0x36/0x50 [mac80211 136d1d948548ad6cca697df0da0a13c0a2333310]
> Jun 16 20:56:37 askasleikir kernel: b43_pio_tx+0x373/0x390 [b43 0f6039cbd530df6f28ebbb52898f2f67b84598dd]
> Jun 16 20:56:37 askasleikir kernel: ? __schedule+0x44b/0x1400
> Jun 16 20:56:37 askasleikir kernel: b43_tx_work+0x57/0x130 [b43 0f6039cbd530df6f28ebbb52898f2f67b84598dd]
> Jun 16 20:56:37 askasleikir kernel: process_one_work+0x1c7/0x3d0
> Jun 16 20:56:37 askasleikir kernel: worker_thread+0x51/0x390
> Jun 16 20:56:37 askasleikir kernel: ? __pfx_worker_thread+0x10/0x10
> Jun 16 20:56:37 askasleikir kernel: kthread+0xde/0x110
> Jun 16 20:56:37 askasleikir kernel: ? __pfx_kthread+0x10/0x10
> Jun 16 20:56:37 askasleikir kernel: ret_from_fork+0x2c/0x50
> Jun 16 20:56:37 askasleikir kernel: </TASK>
> Jun 16 20:56:37 askasleikir kernel: ---[ end trace 0000000000000000 ]---
> 
> I suspect change introduced when addressing a compiler warning cased the error.
> 
> https://patchwork.kernel.org/project/linux-wireless/patch/20230516183442.536589-1-arnd%40kernel.org/
> 
> The is arch linux and they referred me here.

See Bugzilla for the full thread.

Unfortunately, the reporter can't perform bisection to confirm that
backport of 212457ccbd60db triggers this regression.

Anyway, I'm adding it to regzbot to be sure that it doesn't fall
through cracks unnoticed:

#regzbot introduced: 212457ccbd60db https://bugzilla.kernel.org/show_bug.cgi?id=217582
#regzbot title: fixing incorrect __packed annotation for Clang causes b43 driver fail to start

Thanks.

-- 
An old man doll... just what I always wanted! - Clara