From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755479Ab3KVMZK (ORCPT ); Fri, 22 Nov 2013 07:25:10 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:65358 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751956Ab3KVMZI (ORCPT ); Fri, 22 Nov 2013 07:25:08 -0500 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, tianyu.lan@intel.com, nm@ti.com, jinchoi@broadcom.com, sebastian.capella@linaro.org Subject: Re: [PATCH V2 2/2] cpufreq: Change freq before suspending governors Date: Fri, 22 Nov 2013 13:37:50 +0100 Message-ID: <2783049.JzUB2QcsZz@vostro.rjw.lan> User-Agent: KMail/4.10.5 (Linux/3.12.0-rc6+; KDE/4.10.5; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, November 22, 2013 04:59:49 PM Viresh Kumar wrote: > Some platforms might want to change frequency before suspending governors. Like: > - Some platform which want to set freq to max to speed up suspend/hibernation > process. > - Some platform (like: Tegra or exynos), set this to min or bootloader's > frequency. > > This patch adds an option for those, so that they can specify this at call to > ->init(), so that cpufreq core can take care of this before suspending system. > > If this variable is not updated by ->init() then its value would be zero and so > core wouldn't do anything. > > Signed-off-by: Viresh Kumar I don't think this is generally necessary, because the suspend/resume routines added by patch [1/2] will be executed very late during suspend or very early during resume and it shouldn't really matter what performance levels the CPUs are at then. The only exception *may* be hibernation, because the amount of time needed to create the image will depend on the current performance level of the boot CPU, but that should be an explicitly special case in my opinion. Thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.