From: Markus Elfring <Markus.Elfring@web.de>
To: "Guangshuo Li" <lgs201920130244@gmail.com>,
kernel@pengutronix.de,
"Thorsten Scherer" <t.scherer@eckelmann.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] siox: fix master memory leak on registration failure
Date: Mon, 21 Sep 2026 12:51:00 +0200 [thread overview]
Message-ID: <2784d61d-99d7-41f0-8c51-7736b788dc6c@web.de> (raw)
In-Reply-To: <20260919181051.3751829-1-lgs201920130244@gmail.com>
…
> +++ b/drivers/siox/siox-core.c
> @@ -753,14 +753,21 @@ int siox_master_register(struct siox_master *smaster)
> smaster->poll_thread = kthread_run(siox_poll_thread, smaster,
> "siox-%d", smaster->busno);
> if (IS_ERR(smaster->poll_thread)) {
> + ret = PTR_ERR(smaster->poll_thread);
Would it be nicer to use this variable assignment directly before
the goto statement?
> smaster->active = 0;
> - return PTR_ERR(smaster->poll_thread);
> + goto err_put_device;
> }
…
Regards,
Markus
next prev parent reply other threads:[~2026-09-21 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 18:10 Guangshuo Li
2026-09-21 10:51 ` Markus Elfring [this message]
2026-09-21 13:02 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2784d61d-99d7-41f0-8c51-7736b788dc6c@web.de \
--to=markus.elfring@web.de \
--cc=kernel@pengutronix.de \
--cc=lgs201920130244@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=t.scherer@eckelmann.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®