From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752243AbbKYTxe (ORCPT ); Wed, 25 Nov 2015 14:53:34 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:59182 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbbKYTxa (ORCPT ); Wed, 25 Nov 2015 14:53:30 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Bjorn Helgaas , David Daney , David Daney , Marc Zyngier , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, "Sean O. Stalley" , linux-pci@vger.kernel.org, Bjorn Helgaas Subject: Re: [RFC PATCH] PCI/pci-host-generic: Add support for Cavium Thunder fixed BARs. Date: Wed, 25 Nov 2015 20:52:48 +0100 Message-ID: <2789794.TBZL2yW2b6@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151125170652.GC1380@localhost> References: <1443488184-12633-1-git-send-email-ddaney.cavm@gmail.com> <20151125170652.GC1380@localhost> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:GgzHTuMy39mWrnMG+hgtecc9JASi6DdZZPEHPKbhTlog0CWXlpM kXtnZHEMG0ZHpV6df1dVMschYar1IJK+cEj6dc1+e1Tuz6YZwoF3PsnBDS1exdT3yW9byvJ FvcPn+h4R8O7oPMbUwUUNJVQVfagLx0n9En6OKVa5/N5xyNDBzEagkOoD1gDpVmCbKo9n+T 4Ax0CGmkL8GlFOGQSelfw== X-UI-Out-Filterresults: notjunk:1;V01:K0:ikfwj+iPPnA=:8U4Na3j2QcJhkU2epEGSty +FOQEZfzlnTHHLnlWohpLxtjuz+oWqDjzj01J/V7S6jtykGFj/F5YGqRmQv8B/Ywbu5409ETN ygakyKvCVx+BRkGZ8DcfKwXr8ulr603r3soNwgBV6W0Ju/vpvuBjpu8gsGBbBP5wC/ETUwFNm cukGtGv2yb1IxhZTjSHJBRSD55BWZ5Hr2LDymkzk183auEzgB+3oy8fyOIRTHNoX29TdHQOmM H7BLZezFaJ8MtH+rH2dM+5WYq67PNWd7mC93WTzh9Zaua/32IO8c+tJ6Aj3EFqGwvjssCgtyK xCG+aCr0FdKjss9ajOsw72cL7JhMw7fyi/QojSoF9wHJwKJIJgvBQ4AJ/ImcoHKh9OCJDPGYu slRgEJFv2MEmR/0eO2MTGlSWg/nFsKchZ5fz8jW4dmjaJeZUkhn+ID7VQTKkoFA9+6ZOjSAou X8kERMVMWg8Vq2Wkuq+1kmpBy0X6NxEBKptvzueffNvxpiWyJ5MNIbII3VpBb/nEqbcp3NgFu nDTsj3zE3wRjPmpznL5K8lP/4aywziHyhgg7djkrs8q5D7C7aSflGksTMGkdBGhZ5CD/hSLQI tbS7yuKfd04vYao3mhIloaFWi3X2bqK06vKqr9TsoDQR269BW+ajFfKoTdRWdWoCkpyOcWhbL dq3LsftTboJmP0d3+e1JstpEvrlhAWLu/clZN/ad4wXbmVv1ZI3d1ieH1chf4JxkjnkyFs0Gb 9RZryZ0w+hy4jXZb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 25 November 2015 11:06:52 Bjorn Helgaas wrote: > > On Mon, Sep 28, 2015 at 05:56:24PM -0700, David Daney wrote: > > From: David Daney > > > > Early versions of the Cavium Thunder CN88XX processor are missing > > Enhanced Allocation (EA) capabilities for the fixed BAR addresses used > > by the on-SoC hardware blocks. > > > > Add config access functions that synthesize the missing EA > > capabilities for versions that are missing that information. Since > > this is a little hacky, gate the inclusion of the code with a new > > Kconfig variable. > > > > Signed-off-by: David Daney > > What about this one? Do we still need it? This version looks like it > still has some debug code and it feels like a lot of hard-coding of > config offsets; it'd be nice if it could be more table-driven. But > maybe this isn't needed anymore anyway. I still think it doesn't belong into the generic driver. We have the abstraction for drivers based on the compatible string to handle nonstandard PCI host bridges, and the generic driver should really just handle the generic code. It's easy enough to split out the common parts if we want to reuse some of this, or to move them into drivers/pci/*.c for others to reuse too. Arnd