From: Ping-Ke Shih <pkshih@realtek.com>
To: Ping-Ke Shih <pkshih@realtek.com>,
Sang-Heon Jeon <ekffu200098@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH rtw-next v2 1/2] wifi: rtlwifi: rtl8821ae: remove conditional return with no effect
Date: Mon, 27 Jul 2026 02:09:25 +0000 [thread overview]
Message-ID: <278a0e98f19847368eb40c330f39b10a@realtek.com> (raw)
In-Reply-To: <a46d352db44243d0a18e2312d614cde1@realtek.com>
Ping-Ke Shih <pkshih@realtek.com> wrote:
> Sang-Heon Jeon <ekffu200098@gmail.com> wrote:
> > Both branches of the check return the same value, so the check has
> > no effect. Remove it and return the value directly.
> >
> > This is the result of running the Coccinelle script from
> > scripts/coccinelle/misc/cond_return_no_effect.cocci.
> >
> > Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
For the record, I'd make subject more specific:
wifi: rtlwifi: rtl8821ae: remove conditional return with no effect in _rtl8821ae_llt_write()
next prev parent reply other threads:[~2026-07-27 2:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-26 13:40 [PATCH rtw-next v2 0/2] wifi: rtlwifi/rtw89: remove conditional returns " Sang-Heon Jeon
2026-07-26 13:40 ` [PATCH rtw-next v2 1/2] wifi: rtlwifi: rtl8821ae: remove conditional return " Sang-Heon Jeon
2026-07-27 2:04 ` Ping-Ke Shih
2026-07-27 2:09 ` Ping-Ke Shih [this message]
2026-07-30 5:36 ` Ping-Ke Shih
2026-07-26 13:40 ` [PATCH rtw-next v2 2/2] wifi: rtw89: " Sang-Heon Jeon
2026-07-27 2:06 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=278a0e98f19847368eb40c330f39b10a@realtek.com \
--to=pkshih@realtek.com \
--cc=ekffu200098@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®