From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754710AbdBHPbZ (ORCPT ); Wed, 8 Feb 2017 10:31:25 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:50708 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753259AbdBHPbW (ORCPT ); Wed, 8 Feb 2017 10:31:22 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4D6C3606DB Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=shankerd@codeaurora.org Reply-To: shankerd@codeaurora.org Subject: Re: [PATCH 1/9] irqchip/gic-v3-its: Fix command buffer allocation References: <20170201173833.12630-1-rrichter@cavium.com> <20170201173833.12630-2-rrichter@cavium.com> <87tw847njl.fsf@on-the-bus.cambridge.arm.com> <20170208144328.GS5020@rric.localdomain> To: Robert Richter , Marc Zyngier Cc: Thomas Gleixner , Jason Cooper , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Shanker Donthineni Message-ID: <278df776-4d6d-3b89-7a94-effaafcebeb0@codeaurora.org> Date: Wed, 8 Feb 2017 09:31:00 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170208144328.GS5020@rric.localdomain> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc, In teardown path, code is still calling 'kfree(its->cmd_base)' to free memory, this should be changed to 'free_pages(get_order(ITS_CMD_QUEUE_SZ). On 02/08/2017 08:43 AM, Robert Richter wrote: > On 08.02.17 14:41:18, Marc Zyngier wrote: >> On Wed, Feb 01 2017 at 5:38:25 pm GMT, Robert Richter > wrote: >>> The its command buffer must be page aligned, but kzalloc() is not >>> guaranteed to be (though it is mostly when allocating 64k). Use >>> __get_free_pages() as this is used for other buffers as well. >>> >>> Signed-off-by: Robert Richter >> I'm still going through this series, but as this is an obvious fix, I've >> cherry-picked it for 4.11. > That was actually my intention, thus I placed it first. > > -Robert > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Shanker Donthineni Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.