From: "Martin Povišer" <povik+lin@cutebit.org>
To: Janne Grunau <janne@jannau.net>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Philipp Zabel <p.zabel@pengutronix.de>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
asahi@lists.linux.dev, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] arm64: dts: apple: t8103: Add MCA and its support
Date: Tue, 6 Sep 2022 01:52:03 +0200 [thread overview]
Message-ID: <27908832-4453-4199-A899-7B93ABD1216B@cutebit.org> (raw)
In-Reply-To: <20220905223927.GE10102@jannau.net>
Ciao Janne, thanks for the comments and fixes.
> On 6. 9. 2022, at 0:39, Janne Grunau <janne@jannau.net> wrote:
>
> On 2022-08-24 18:07:13 +0200, Martin Povišer wrote:
>> Add the MCA I2S transceiver node and its supporting NCO, ADMAC nodes.
>>
>> Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
>> ---
>> arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 4 ++
>> arch/arm64/boot/dts/apple/t8103.dtsi | 73 +++++++++++++++++++++++
>> 2 files changed, 77 insertions(+)
>> + /*
>> + * This is a fabulated representation of the input clock
>> + * to NCO since we don't know the true clock tree.
>> + */
>> + nco_clkref: clock-ref {
>
> clocks are not valid inside "simple-bus", the node name "clock-ref"
> conflicts in "/", maybe use "clock-nco"?
I would smuggle ‘ref’ or something to that effect into the name,
otherwise sure, let’s do it.
Martin
next prev parent reply other threads:[~2022-09-05 23:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 16:07 [PATCH v3 0/4] ASoC platform driver for Apple MCA Martin Povišer
2022-08-24 16:07 ` [PATCH v3 1/4] dt-bindings: sound: Add Apple MCA I2S transceiver Martin Povišer
2022-08-25 6:13 ` Krzysztof Kozlowski
2022-08-24 16:07 ` [PATCH v3 2/4] arm64: dts: apple: t8103: Add MCA and its support Martin Povišer
2022-09-05 22:39 ` Janne Grunau
2022-09-05 23:52 ` Martin Povišer [this message]
2022-08-24 16:07 ` [PATCH v3 3/4] ASoC: apple: mca: Start new platform driver Martin Povišer
2022-08-24 16:07 ` [PATCH v3 4/4] ASoC: apple: mca: Add locking Martin Povišer
2022-08-25 15:28 ` (subset) [PATCH v3 0/4] ASoC platform driver for Apple MCA Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27908832-4453-4199-A899-7B93ABD1216B@cutebit.org \
--to=povik+lin@cutebit.org \
--cc=alsa-devel@alsa-project.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=janne@jannau.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®