From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DADE6C4360F for ; Fri, 5 Apr 2019 12:42:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B61F220700 for ; Fri, 5 Apr 2019 12:42:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730827AbfDEMmW (ORCPT ); Fri, 5 Apr 2019 08:42:22 -0400 Received: from mga09.intel.com ([134.134.136.24]:11901 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726626AbfDEMmW (ORCPT ); Fri, 5 Apr 2019 08:42:22 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2019 05:42:21 -0700 X-IronPort-AV: E=Sophos;i="5.60,312,1549958400"; d="scan'208";a="289025662" Received: from jkrzyszt-desk.igk.intel.com ([172.22.244.18]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Apr 2019 05:42:19 -0700 Message-ID: <2790d298adb0d57a67a0a3c9bc9aa8c7c08f0a0d.camel@linux.intel.com> Subject: Re: [RFC PATCH] drm/i915: Don't panic on non-empty list of free cachelines From: Janusz Krzysztofik To: Chris Wilson , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi Cc: David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, michal.wajdeczko@intel.com Date: Fri, 05 Apr 2019 14:42:16 +0200 In-Reply-To: <155446684177.8259.3979238916498240519@skylake-alporthouse-com> References: <20190405121331.6524-1-janusz.krzysztofik@linux.intel.com> <155446684177.8259.3979238916498240519@skylake-alporthouse-com> Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-04-05 at 13:20 +0100, Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-04-05 13:13:31) > > From: Janusz Krzysztofik > > > > If there are active users of a device during driver unbind, the > > driver > > now panics on non-empty list of free cachelines. > > This panic is there to say that fini is being called with active > contexts, that it is being called too early. Those requests should be > cleaned up first, unpinning the contexts and resources, and so > letting > the timeline be freed. OK, I see. But why panic? Maybe a WARN() would be enough. Thanks, Janusz > -Chris > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel