From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751550AbdBXV6Q (ORCPT ); Fri, 24 Feb 2017 16:58:16 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:2883 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751277AbdBXV6H (ORCPT ); Fri, 24 Feb 2017 16:58:07 -0500 X-PGP-Universal: processed; by imgpgp01.kl.imgtec.org on Fri, 24 Feb 2017 23:01:11 +0000 From: Paul Burton To: Dmitry Torokhov , Ralf Baechle , James Hogan CC: Miguel Ojeda Sandonis , , Javier Martinez Canillas Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches Date: Fri, 24 Feb 2017 13:56:41 -0800 Message-ID: <2792939.Kfs5VkVaFl@np-p-burton> Organization: Imagination Technologies In-Reply-To: <20170221053911.GA3229@dtor-ws> References: <20170221053911.GA3229@dtor-ws> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3094744.pi1CZ99Whn"; micalg=pgp-sha256; protocol="application/pgp-signature" X-Originating-IP: [10.20.1.33] X-ESG-ENCRYPT-TAG: 1b7d744b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart3094744.pi1CZ99Whn Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Dmitry, On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote: > The OF device table must be terminated, otherwise we'll be walking past > it and into areas unknown. > > This causes KASAN errors reported by 0day kernel testing robot. > > Reported-by: Fengguang Wu > Tested-by: Fengguang Wu > Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple > ASCII...") Cc: stable@vger.kernel.org > Signed-off-by: Dmitry Torokhov An essentially identical patch was already submitted over here: https://patchwork.kernel.org/patch/9493973/ I'm not sure how it ought to get into mainline - since the driver went through the MIPS tree perhaps this fix can too? Thanks, Paul > --- > drivers/auxdisplay/img-ascii-lcd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/auxdisplay/img-ascii-lcd.c > b/drivers/auxdisplay/img-ascii-lcd.c index bf43b5d2aafc..83f1439e57fd > 100644 > --- a/drivers/auxdisplay/img-ascii-lcd.c > +++ b/drivers/auxdisplay/img-ascii-lcd.c > @@ -218,6 +218,7 @@ static const struct of_device_id img_ascii_lcd_matches[] > = { { .compatible = "img,boston-lcd", .data = &boston_config }, > { .compatible = "mti,malta-lcd", .data = &malta_config }, > { .compatible = "mti,sead3-lcd", .data = &sead3_config }, > + { /* sentinel */ } > }; > > /** --nextPart3094744.pi1CZ99Whn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEELIGR03D5+Fg+69wPgiDZ+mk8HGUFAliwrBkACgkQgiDZ+mk8 HGV01w/+KhqpPd7sGc0yZ82Q9SIDYyf6fvir5wIqRE/pQqBNbCrukXs77LyvRiqS RQBEpS2CPnvf6e6lCsEfXHU4YT1UJrhgB+olQcWLnN0/GAtq0/7hODkDkaOJZPPx 3DoQb/7OXeuUiGa/Iish4RppH+6anQEN7ztgfFQCogrQpFH+n6GfPJypzkB23v5T qotRkjAGGhbUKwtBrllNUUaqPBoxZ53laqrXo6dAdJwF2i/0X0FdFQs3eXJQ+dN8 wLlBFib41BFo8U2FdmyMa1QE44LHch0KELVe0MQ+XqtWsTZlpJde7Dx/6y/OE26/ H6m4z88ZKNYRMNGNX14UQH8fS51u6aqbucfkvnjpO83LA8e1FPp/drizPcQZ0TS4 CcJGd3q0INEEJvfeeEXindzyVYJFAvZ+SS+63CzEODe9NcqtUbhF94IC/wMYmLts nCajjYyngGvp8/4ha0jTPdaPkQ9EfVUHJzUOFmF0h9zbRJVARiAKhot1aES7GTZN qkuHg+VsbCO30PXn0qWqppwtcwH1pdfE+6/PvKgTqM2zfsVuX/N/uLKBslVDiaMi BfZADPGYf14Q0uE9MTquZC2z3KgRA7BQRy2rFzRPrVdlLFDjTU8Nf4NenSBnvuoH 21NI7py1iEMOz4MXOhfPEBsOdMRAn4Nic1mvzV4BdE//WyqNlRo= =c4DX -----END PGP SIGNATURE----- --nextPart3094744.pi1CZ99Whn--