From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1422644AbcFGQfX (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Jun 2016 12:35:23 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:46129 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1161033AbcFGQfW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Jun 2016 12:35:22 -0400
Subject: Re: [RFC PATCH 3/6] mm/userfaultfd: add __mcopy_atomic_hugetlb for
 huge page UFFDIO_COPY
To: Hillf Danton <hillf.zj@alibaba-inc.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <1465235131-6112-1-git-send-email-mike.kravetz@oracle.com>
 <1465235131-6112-4-git-send-email-mike.kravetz@oracle.com>
 <01ad01d1c085$b61fdd60$225f9820$@alibaba-inc.com>
Cc: "'Andrea Arcangeli'" <aarcange@redhat.com>,
        "'Hugh Dickins'" <hughd@google.com>,
        "'Dave Hansen'" <dave.hansen@linux.intel.com>,
        "'Kirill A. Shutemov'" <kirill.shutemov@linux.intel.com>,
        "'Naoya Horiguchi'" <n-horiguchi@ah.jp.nec.com>,
        "'Michal Hocko'" <mhocko@suse.com>,
        "'Andrew Morton'" <akpm@linux-foundation.org>
From: Mike Kravetz <mike.kravetz@oracle.com>
Message-ID: <279444f1-bfaa-d730-1cde-38552d3c4610@oracle.com>
Date: Tue, 7 Jun 2016 09:35:00 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <01ad01d1c085$b61fdd60$225f9820$@alibaba-inc.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Source-IP: aserv0021.oracle.com [141.146.126.233]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/06/2016 11:27 PM, Hillf Danton wrote:
>> @@ -182,6 +354,13 @@ retry:
>>  		goto out_unlock;
>>
>>  	/*
>> +	 * If this is a HUGETLB vma, pass off to appropriate routine
>> +	 */
>> +	if (dst_vma->vm_flags & VM_HUGETLB)
> 
> Use is_vm_hugetlb_page()?
> And in cases in subsequent patches?
> 
> Hillf

Yes, that would be better.  Thanks.

-- 
Mike Kravetz