From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F366C10F13 for ; Thu, 11 Apr 2019 15:23:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6ACB2083E for ; Thu, 11 Apr 2019 15:23:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726752AbfDKPXa convert rfc822-to-8bit (ORCPT ); Thu, 11 Apr 2019 11:23:30 -0400 Received: from mailoutvs57.siol.net ([185.57.226.248]:52663 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726264AbfDKPX3 (ORCPT ); Thu, 11 Apr 2019 11:23:29 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 5F8B5520A47; Thu, 11 Apr 2019 17:23:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta09.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta09.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id iAfPx3ctmZU4; Thu, 11 Apr 2019 17:23:27 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id DAD1452189E; Thu, 11 Apr 2019 17:23:26 +0200 (CEST) Received: from jernej-laptop.localnet (cpe-86-58-52-202.static.triera.net [86.58.52.202]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id 0E65E520A47; Thu, 11 Apr 2019 17:23:25 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: =?ISO-8859-1?Q?Cl=E9ment_P=E9ron?= Cc: Rob Herring , Maxime Ripard , Chen-Yu Tsai , Icenowy Zheng , Jagan Teki , devicetree , linux-kernel , linux-arm-kernel , dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6 Date: Thu, 11 Apr 2019 17:23:25 +0200 Message-ID: <2797515.ZAugZ1JPiN@jernej-laptop> In-Reply-To: References: <20190411105720.32357-1-peron.clem@gmail.com> <2957024.jOddxINRMN@jernej-laptop> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne četrtek, 11. april 2019 ob 17:20:04 CEST je Clément Péron napisal(a): > Hi, > > On Thu, 11 Apr 2019 at 17:05, Jernej Škrabec wrote: > > Dne četrtek, 11. april 2019 ob 12:57:16 CEST je Clément Péron napisal(a): > > > Add the mali gpu node to the H6 device-tree. > > > > > > Signed-off-by: Clément Péron > > > --- > > > > > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 14 ++++++++++++++ > > > 1 file changed, 14 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index > > > e0dc4a05c1ba..196753110434 100644 > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > @@ -157,6 +157,20 @@ > > > > > > allwinner,sram = <&ve_sram 1>; > > > > > > }; > > > > > > + gpu: gpu@1800000 { > > > + compatible = "allwinner,sun50i-h6-mali", > > > + "arm,mali-t720"; > > > + reg = <0x01800000 0x4000>; > > > + interrupts = > > > IRQ_TYPE_LEVEL_HIGH>, > > > > > + > > > IRQ_TYPE_LEVEL_HIGH>, > > > > > + > > > IRQ_TYPE_LEVEL_HIGH>; > > > > > + interrupt-names = "job", "mmu", "gpu"; > > > + clocks = <&ccu CLK_GPU>, <&ccu CLK_BUS_GPU>; > > > + clock-names = "core", "bus"; > > > + resets = <&ccu RST_BUS_GPU>; > > > + status = "disabled"; > > > > Usually self sufficient peripherals are enabled by default in DTSI. > > I follow the other Mali Midgard (rk3399, rk3288) syntax. > But I think you're right here, will go for an update I think. > I quickly checked A64 and H5 DTSI and both have GPU enabled by default (status property is not set). Best regards, Jernej > Clement > > > > + }; > > > + > > > > > > syscon: syscon@3000000 { > > > > > > compatible = "allwinner,sun50i-h6-system- > > > > control", > > > > > "allwinner,sun50i-a64- > > > > system-control";