mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: dhowells@redhat.com, LKLM <linux-kernel@vger.kernel.org>,
	LSM <linux-security-module@vger.kernel.org>
Subject: Re: [PATCH] Smack: setprocattr memory leak fix
Date: Thu, 23 Aug 2012 13:48:37 +0100	[thread overview]
Message-ID: <27988.1345726117@warthog.procyon.org.uk> (raw)
In-Reply-To: <50352873.9070706@schaufler-ca.com>

Casey Schaufler <casey@schaufler-ca.com> wrote:

> From: Casey Schaufler <casey@schaufler-ca.com>
> Subject: [PATCH] Smack: setprocattr memory leak fix
> 
> The data structure allocations being done in prepare_creds
> are duplicated in smack_setprocattr. This results in the
> structure allocated in prepare_creds being orphaned and
> never freed. The duplicate code is removed from
> smack_setprocattr.
> 
> Targeted for git://git.gitorious.org/smack-next/kernel.git
> 
> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>

Acked-by: David Howells <dhowells@redhat.com>

Note that I do have a patch to make Smack share rule lists - I've posted it a
number of times, but I take it you're not interested.

  5707  06/13 [To:casey@schauf]  [PATCH 1/3] Smack: Constify some pointers<<Mak
  5708  06/13   [To:casey@schauf]  [PATCH 2/3] Smack: Further constification<<M
  5709  06/13   [To:casey@schauf]  [PATCH 3/3] Smack: Use rule list tail sharin

David

  reply	other threads:[~2012-08-23 12:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-22 18:44 Casey Schaufler
2012-08-23 12:48 ` David Howells [this message]
2012-08-23 15:58   ` Casey Schaufler
2012-08-23 16:51 ` Casey Schaufler
2012-08-22 21:49 Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27988.1345726117@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=casey@schaufler-ca.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome